From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Pankaj Gupta" <pankaj.gupta.linux@gmail.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marek Kedzierski" <mkedzier@redhat.com>
Subject: [PATCH v2 4/6] util/oslib-posix: Avoid creating a single thread with MADV_POPULATE_WRITE
Date: Thu, 22 Jul 2021 14:36:33 +0200 [thread overview]
Message-ID: <20210722123635.60608-5-david@redhat.com> (raw)
In-Reply-To: <20210722123635.60608-1-david@redhat.com>
Let's simplify the case when we only want a single thread and don't have
to mess with signal handlers.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
util/oslib-posix.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index a1d309d495..1483e985c6 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -568,6 +568,14 @@ static bool touch_all_pages(char *area, size_t hpagesize, size_t numpages,
}
if (use_madv_populate_write) {
+ /* Avoid creating a single thread for MADV_POPULATE_WRITE */
+ if (context.num_threads == 1) {
+ if (qemu_madvise(area, hpagesize * numpages,
+ QEMU_MADV_POPULATE_WRITE)) {
+ return true;
+ }
+ return false;
+ }
touch_fn = do_madv_populate_write_pages;
} else {
touch_fn = do_touch_pages;
--
2.31.1
next prev parent reply other threads:[~2021-07-22 12:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 12:36 [PATCH v2 0/6] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc() David Hildenbrand
2021-07-22 12:36 ` [PATCH v2 1/6] " David Hildenbrand
2021-07-22 13:31 ` Daniel P. Berrangé
2021-07-22 13:39 ` David Hildenbrand
2021-07-22 13:47 ` Daniel P. Berrangé
2021-07-22 14:13 ` David Hildenbrand
2021-07-22 12:36 ` [PATCH v2 2/6] util/oslib-posix: Introduce and use MemsetContext for touch_all_pages() David Hildenbrand
2021-07-22 12:36 ` [PATCH v2 3/6] util/oslib-posix: Don't create too many threads with small memory or little pages David Hildenbrand
2021-07-27 19:01 ` Dr. David Alan Gilbert
2021-07-28 11:23 ` Pankaj Gupta
2021-07-22 12:36 ` David Hildenbrand [this message]
2021-07-27 19:04 ` [PATCH v2 4/6] util/oslib-posix: Avoid creating a single thread with MADV_POPULATE_WRITE Dr. David Alan Gilbert
2021-07-30 15:13 ` David Hildenbrand
2021-07-28 11:32 ` Pankaj Gupta
2021-07-22 12:36 ` [PATCH v2 5/6] util/oslib-posix: Support concurrent os_mem_prealloc() invocation David Hildenbrand
2021-07-22 12:36 ` [PATCH v2 6/6] util/oslib-posix: Forward SIGBUS to MCE handler under Linux David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722123635.60608-5-david@redhat.com \
--to=david@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mkedzier@redhat.com \
--cc=mst@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).