From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH for-6.1? v2 7/9] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write
Date: Sun, 25 Jul 2021 02:24:14 -1000 [thread overview]
Message-ID: <20210725122416.1391332-8-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210725122416.1391332-1-richard.henderson@linaro.org>
From clang-13:
hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used \
[-Werror,-Wunused-but-set-variable]
It's pretty clear that we meant to write back 'v' after
all that computation and not 'val'.
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/pci-host/pnv_phb4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 54f57c660a..5c375a9f28 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -392,7 +392,7 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t val)
v &= 0xffffffffffff0000ull;
v |= 0x000000000000cfffull & val;
}
- *tptr = val;
+ *tptr = v;
break;
}
case IODA3_TBL_MBT:
--
2.25.1
next prev parent reply other threads:[~2021-07-25 12:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 12:24 [PATCH for-6.1? v2 0/9] Fixes for clang-13 Richard Henderson
2021-07-25 12:24 ` [PATCH for-6.1? v2 1/9] nbd/server: Mark variable unused in nbd_negotiate_meta_queries Richard Henderson
2021-07-26 10:16 ` Vladimir Sementsov-Ogievskiy
2021-07-26 14:53 ` Eric Blake
2021-07-25 12:24 ` [PATCH for-6.1? v2 2/9] accel/tcg: Remove unused variable in cpu_exec Richard Henderson
2021-07-25 12:24 ` [PATCH for-6.1? v2 3/9] util/selfmap: Discard mapping on error Richard Henderson
2021-07-26 15:37 ` Eric Blake
2021-07-25 12:24 ` [PATCH for-6.1? v2 4/9] net/checksum: Remove unused variable in net_checksum_add_iov Richard Henderson
2021-07-26 15:38 ` Eric Blake
2021-07-25 12:24 ` [PATCH for-6.1? v2 5/9] hw/audio/adlib: Remove unused variable in adlib_callback Richard Henderson
2021-07-25 12:24 ` [PATCH for-6.1? v2 6/9] hw/ppc/spapr_events: Remove unused variable from check_exception Richard Henderson
2021-07-25 12:24 ` Richard Henderson [this message]
2021-07-25 21:27 ` [PATCH for-6.1? v2 7/9] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write Philippe Mathieu-Daudé
2021-07-26 4:58 ` Benjamin Herrenschmidt
2021-07-26 6:58 ` Cédric Le Goater
2021-07-25 12:24 ` [PATCH for-6.1? v2 8/9] linux-user/syscall: Remove unused variable from execve Richard Henderson
2021-07-25 12:24 ` [PATCH for-6.1? v2 9/9] tests/unit: Remove unused variable from test_io Richard Henderson
2021-07-26 17:10 ` [PATCH for-6.1? v2 0/9] Fixes for clang-13 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210725122416.1391332-8-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).