qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	peterx@redhat.com, "David Hildenbrand" <david@redhat.com>
Subject: [PATCH v3 6/8] cpus: Remove the mutex parameter from do_run_on_cpu()
Date: Wed, 28 Jul 2021 14:31:49 -0400	[thread overview]
Message-ID: <20210728183151.195139-7-peterx@redhat.com> (raw)
In-Reply-To: <20210728183151.195139-1-peterx@redhat.com>

We must use the BQL for do_run_on_cpu() without much choice, it means the
parameter is useless.  Remove it.  Meanwhile use the newly introduced
qemu_cond_wait_iothread() in do_run_on_cpu().

Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 softmmu/cpus.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/softmmu/cpus.c b/softmmu/cpus.c
index e714dfbf2b..9154cd7e78 100644
--- a/softmmu/cpus.c
+++ b/softmmu/cpus.c
@@ -383,8 +383,7 @@ void qemu_init_cpu_loop(void)
 }
 
 static void
-do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data,
-              QemuMutex *mutex)
+do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data)
 {
     struct qemu_work_item wi = {
         .func = func,
@@ -400,14 +399,14 @@ do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data,
     while (!qatomic_mb_read(&wi.done)) {
         CPUState *self_cpu = current_cpu;
 
-        qemu_cond_wait(&qemu_work_cond, mutex);
+        qemu_cond_wait_iothread(&qemu_work_cond);
         current_cpu = self_cpu;
     }
 }
 
 void run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data)
 {
-    do_run_on_cpu(cpu, func, data, &qemu_global_mutex);
+    do_run_on_cpu(cpu, func, data);
 }
 
 static void qemu_cpu_stop(CPUState *cpu, bool exit)
-- 
2.31.1



  parent reply	other threads:[~2021-07-28 18:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 18:31 [PATCH v3 0/8] memory: Sanity checks memory transaction when releasing BQL Peter Xu
2021-07-28 18:31 ` [PATCH v3 1/8] cpus: Export queue work related fields to cpu.h Peter Xu
2021-07-28 18:40   ` Philippe Mathieu-Daudé
2021-07-28 18:31 ` [PATCH v3 2/8] cpus: Move do_run_on_cpu into softmmu/cpus.c Peter Xu
2021-07-28 18:35   ` Philippe Mathieu-Daudé
2021-07-28 18:31 ` [PATCH v3 3/8] memory: Introduce memory_region_transaction_depth_{inc|dec}() Peter Xu
2021-07-28 20:06   ` David Hildenbrand
2021-07-28 18:31 ` [PATCH v3 4/8] memory: Don't do topology update in memory finalize() Peter Xu
2021-07-28 18:31 ` [PATCH v3 5/8] cpus: Use qemu_cond_wait_iothread() where proper Peter Xu
2021-07-28 18:38   ` Philippe Mathieu-Daudé
2021-07-28 18:31 ` Peter Xu [this message]
2021-07-28 18:39   ` [PATCH v3 6/8] cpus: Remove the mutex parameter from do_run_on_cpu() Philippe Mathieu-Daudé
2021-07-28 18:31 ` [PATCH v3 7/8] memory: Assert on no ongoing memory transaction before release BQL Peter Xu
2021-07-28 18:31 ` [PATCH v3 8/8] memory: Delay the transaction pop() until commit completed Peter Xu
2021-09-08 15:30 ` [PATCH v3 0/8] memory: Sanity checks memory transaction when releasing BQL Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210728183151.195139-7-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=david@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).