From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, berrange@redhat.com,
pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com,
mreitz@redhat.com, kwolf@redhat.com, vsementsov@virtuozzo.com,
den@openvz.org, nshirokovskiy@virtuozzo.com, yur@virtuozzo.com,
dim@virtuozzo.com, igor@virtuozzo.com, pkrempa@redhat.com,
libvir-list@redhat.com, stefanha@redhat.com
Subject: [PATCH 3/8] block: realize BlockParentClass for BlockDriverState
Date: Mon, 2 Aug 2021 21:54:11 +0300 [thread overview]
Message-ID: <20210802185416.50877-4-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210802185416.50877-1-vsementsov@virtuozzo.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/block.c b/block.c
index e97ce0b1c8..449f933661 100644
--- a/block.c
+++ b/block.c
@@ -26,6 +26,7 @@
#include "qemu/osdep.h"
#include "block/trace.h"
#include "block/block_int.h"
+#include "block/block-parent.h"
#include "block/blockjob.h"
#include "block/fuse.h"
#include "block/nbd.h"
@@ -7501,6 +7502,47 @@ int bdrv_make_empty(BdrvChild *c, Error **errp)
return 0;
}
+static int bdrv_find_child(const char *parent_id, const char *child_name,
+ BlockDriverState *child_bs, BdrvChild **child,
+ Error **errp)
+{
+ BdrvChild *c, *found = NULL;
+ BlockDriverState *bs;
+
+ bs = bdrv_find_node(parent_id);
+ if (!bs) {
+ return 0;
+ }
+
+ QLIST_FOREACH(c, &bs->children, next) {
+ if ((!child_name || strcmp(c->name, child_name) == 0) &&
+ (!child_bs || child_bs == c->bs))
+ {
+ if (found) {
+ error_setg(errp, "node '%s' has more than one matching child",
+ parent_id);
+ return -EINVAL;
+ } else {
+ found = c;
+ }
+ }
+ }
+
+ if (!found) {
+ error_setg(errp, "node '%s' exists but it doesn't have matching child",
+ parent_id);
+ return -EINVAL;
+ }
+
+ *child = found;
+ return 1;
+}
+
+BlockParentClass block_parent_bdrv = {
+ .name = "block driver",
+ .find_child = bdrv_find_child,
+};
+
/*
* Return the child that @bs acts as an overlay for, and from which data may be
* copied in COW or COR operations. Usually this is the backing file.
@@ -7653,3 +7695,10 @@ BlockDriverState *bdrv_backing_chain_next(BlockDriverState *bs)
{
return bdrv_skip_filters(bdrv_cow_bs(bdrv_skip_filters(bs)));
}
+
+static void block_c_init(void)
+{
+ block_parent_class_register(&block_parent_bdrv);
+}
+
+block_init(block_c_init);
--
2.29.2
next prev parent reply other threads:[~2021-08-02 18:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 18:54 [PATCH RFC 0/8] blockdev-replace Vladimir Sementsov-Ogievskiy
2021-08-02 18:54 ` [PATCH 1/8] block-backend: blk_root(): drop const specifier on return type Vladimir Sementsov-Ogievskiy
2021-08-02 18:54 ` [PATCH 2/8] block: add BlockParentClass class Vladimir Sementsov-Ogievskiy
2021-09-16 8:34 ` Markus Armbruster
2021-09-16 10:12 ` Vladimir Sementsov-Ogievskiy
2021-09-20 5:28 ` Markus Armbruster
2021-08-02 18:54 ` Vladimir Sementsov-Ogievskiy [this message]
2021-08-02 18:54 ` [PATCH 4/8] block/export: realize BlockParentClass functionality Vladimir Sementsov-Ogievskiy
2021-08-02 18:54 ` [PATCH 5/8] qdev: improve find_device_state() to distinguish simple not found case Vladimir Sementsov-Ogievskiy
2021-09-16 10:48 ` Markus Armbruster
2021-09-16 12:54 ` Vladimir Sementsov-Ogievskiy
2021-08-02 18:54 ` [PATCH 6/8] qdev: realize BlockParentClass Vladimir Sementsov-Ogievskiy
2021-09-20 6:08 ` Markus Armbruster
2021-08-02 18:54 ` [PATCH 7/8] block: improve bdrv_replace_node_noperm() Vladimir Sementsov-Ogievskiy
2021-08-02 18:54 ` [PATCH 8/8] qapi: add blockdev-replace command Vladimir Sementsov-Ogievskiy
2021-09-20 6:44 ` Markus Armbruster
2021-09-20 10:02 ` Vladimir Sementsov-Ogievskiy
2021-09-23 10:09 ` Markus Armbruster
2021-09-23 11:54 ` Vladimir Sementsov-Ogievskiy
2021-09-20 11:25 ` Vladimir Sementsov-Ogievskiy
2021-09-02 9:28 ` [PATCH RFC 0/8] blockdev-replace Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802185416.50877-4-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=dim@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=igor@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=nshirokovskiy@virtuozzo.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=yur@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).