From: Andrew Jones <drjones@redhat.com>
To: Yanan Wang <wangyanan55@huawei.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Pierre Morel" <pmorel@linux.ibm.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Pankaj Gupta" <pankaj.gupta.linux@gmail.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Greg Kurz" <groug@kaod.org>,
"Halil Pasic" <pasic@linux.ibm.com>,
wanghaibin.wang@huawei.com, yuzenghui@huawei.com,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH for-6.2 v4 01/14] machine: Minor refactor/cleanup for the smp parsers
Date: Tue, 3 Aug 2021 10:20:08 +0200 [thread overview]
Message-ID: <20210803082008.o2trfetf4pcrrzso@gator.home> (raw)
In-Reply-To: <20210803080527.156556-2-wangyanan55@huawei.com>
On Tue, Aug 03, 2021 at 04:05:14PM +0800, Yanan Wang wrote:
> To pave the way for the functional improvement in later patches,
> make some refactor/cleanup for the smp parsers, including using
> local maxcpus instead of ms->smp.max_cpus in the calculation,
> defaulting dies to 0 initially like other members, cleanup the
> sanity check for dies.
>
> No functional change intended.
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
> hw/core/machine.c | 19 +++++++++++--------
> hw/i386/pc.c | 23 ++++++++++++++---------
> 2 files changed, 25 insertions(+), 17 deletions(-)
>
Reviewed-by: Andrew Jones <drjones@redhat.com>
next prev parent reply other threads:[~2021-08-03 8:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 8:05 [PATCH for-6.2 v4 00/14] machine: smp parsing fixes and improvement Yanan Wang
2021-08-03 8:05 ` [PATCH for-6.2 v4 01/14] machine: Minor refactor/cleanup for the smp parsers Yanan Wang
2021-08-03 8:20 ` Andrew Jones [this message]
2021-08-03 8:05 ` [PATCH for-6.2 v4 02/14] machine: Uniformly use maxcpus to calculate the omitted parameters Yanan Wang
2021-08-06 4:57 ` Pankaj Gupta
2021-08-03 8:05 ` [PATCH for-6.2 v4 03/14] machine: Set the value of cpus to match maxcpus if it's omitted Yanan Wang
2021-08-03 8:05 ` [PATCH for-6.2 v4 04/14] machine: Improve the error reporting of smp parsing Yanan Wang
2021-08-06 4:52 ` Pankaj Gupta
2021-08-03 8:05 ` [PATCH for-6.2 v4 05/14] hw: Add compat machines for 6.2 Yanan Wang
2021-08-03 8:05 ` [PATCH for-6.2 v4 06/14] machine: Prefer cores over sockets in smp parsing since 6.2 Yanan Wang
2021-08-06 4:41 ` Pankaj Gupta
2021-08-06 7:54 ` wangyanan (Y)
2021-08-06 9:22 ` Pankaj Gupta
2021-08-03 8:05 ` [PATCH for-6.2 v4 07/14] machine: Use ms instead of global current_machine in sanity-check Yanan Wang
2021-08-03 8:05 ` [PATCH for-6.2 v4 08/14] machine: Tweak the order of topology members in struct CpuTopology Yanan Wang
2021-08-03 8:05 ` [PATCH for-6.2 v4 09/14] machine: Make smp_parse generic enough for all arches Yanan Wang
2021-08-03 8:05 ` [PATCH for-6.2 v4 10/14] machine: Remove smp_parse callback from MachineClass Yanan Wang
2021-08-03 8:05 ` [PATCH for-6.2 v4 11/14] machine: Move smp_prefer_sockets to struct SMPCompatProps Yanan Wang
2021-08-03 8:05 ` [PATCH for-6.2 v4 12/14] machine: Put all sanity-check in the generic SMP parser Yanan Wang
2021-08-03 8:23 ` Andrew Jones
2021-08-06 4:45 ` Pankaj Gupta
2021-08-03 8:05 ` [PATCH for-6.2 v4 13/14] machine: Split out the smp parsing code Yanan Wang
2021-08-03 8:28 ` Andrew Jones
2021-08-03 8:05 ` [PATCH for-6.2 v4 14/14] tests/unit: Add a unit test for smp parsing Yanan Wang
2021-08-03 8:37 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803082008.o2trfetf4pcrrzso@gator.home \
--to=drjones@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=mst@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wanghaibin.wang@huawei.com \
--cc=wangyanan55@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).