From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Willian Rampazzo <wrampazz@redhat.com>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
"Niteesh G . S ." <niteesh.gs@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [PATCH v3 21/25] python/aqmp: add _raw() execution interface
Date: Tue, 3 Aug 2021 14:29:37 -0400 [thread overview]
Message-ID: <20210803182941.504537-22-jsnow@redhat.com> (raw)
In-Reply-To: <20210803182941.504537-1-jsnow@redhat.com>
This is added in anticipation of wanting it for a synchronous wrapper
for the iotest interface. Normally, execute() and execute_msg() both
raise QMP errors in the form of Python exceptions.
Many iotests expect the entire reply as-is. To reduce churn there, add a
private execution interface that will ease transition churn. However, I
do not wish to encourage its use, so it will remain a private interface.
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/aqmp/qmp_client.py | 51 ++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/python/qemu/aqmp/qmp_client.py b/python/qemu/aqmp/qmp_client.py
index 879348feaaa..82e9dab124c 100644
--- a/python/qemu/aqmp/qmp_client.py
+++ b/python/qemu/aqmp/qmp_client.py
@@ -484,6 +484,57 @@ async def _execute(self, msg: Message, assign_id: bool = True) -> Message:
exec_id = await self._issue(msg)
return await self._reply(exec_id)
+ @upper_half
+ @require(Runstate.RUNNING)
+ async def _raw(
+ self,
+ msg: Union[Message, Mapping[str, object], bytes],
+ assign_id: bool = True,
+ ) -> Message:
+ """
+ Issue a raw `Message` to the QMP server and await a reply.
+
+ :param msg:
+ A Message to send to the server. It may be a `Message`, any
+ Mapping (including Dict), or raw bytes.
+ :param assign_id:
+ Assign an arbitrary execution ID to this message. If
+ `False`, the existing id must either be absent (and no other
+ such pending execution may omit an ID) or a string. If it is
+ a string, it must not start with '__aqmp#' and no other such
+ pending execution may currently be using that ID.
+
+ :return: Execution reply from the server.
+
+ :raise ExecInterruptedError:
+ When the reply could not be retrieved because the connection
+ was lost, or some other problem.
+ :raise TypeError:
+ When assign_id is `False`, an ID is given, and it is not a string.
+ :raise ValueError:
+ When assign_id is `False`, but the ID is not usable;
+ Either because it starts with '__aqmp#' or it is already in-use.
+ """
+ # 1. convert generic Mapping or bytes to a QMP Message
+ # 2. copy Message objects so that we assign an ID only to the copy.
+ msg = Message(msg)
+
+ exec_id = msg.get('id')
+ if not assign_id and 'id' in msg:
+ if not isinstance(exec_id, str):
+ raise TypeError(f"ID ('{exec_id}') must be a string.")
+ if exec_id.startswith('__aqmp#'):
+ raise ValueError(
+ f"ID ('{exec_id}') must not start with '__aqmp#'."
+ )
+
+ if not assign_id and exec_id in self._pending:
+ raise ValueError(
+ f"ID '{exec_id}' is in-use and cannot be used."
+ )
+
+ return await self._execute(msg, assign_id=assign_id)
+
@upper_half
@require(Runstate.RUNNING)
async def execute_msg(self, msg: Message) -> object:
--
2.31.1
next prev parent reply other threads:[~2021-08-03 18:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 18:29 [PATCH v3 00/25] python: introduce Asynchronous QMP package John Snow
2021-08-03 18:29 ` [PATCH v3 01/25] python/aqmp: add asynchronous QMP (AQMP) subpackage John Snow
2021-08-03 18:29 ` [PATCH v3 02/25] python/aqmp: add error classes John Snow
2021-08-03 18:29 ` [PATCH v3 03/25] python/pylint: Add exception for TypeVar names ('T') John Snow
2021-08-03 18:29 ` [PATCH v3 04/25] python/aqmp: add asyncio compatibility wrappers John Snow
2021-08-03 18:29 ` [PATCH v3 05/25] python/aqmp: add generic async message-based protocol support John Snow
2021-08-03 18:29 ` [PATCH v3 06/25] python/aqmp: add runstate state machine to AsyncProtocol John Snow
2021-08-05 21:02 ` Eric Blake
2021-08-05 21:30 ` John Snow
2021-08-03 18:29 ` [PATCH v3 07/25] python/aqmp: Add logging utility helpers John Snow
2021-08-17 19:14 ` Eric Blake
2021-08-03 18:29 ` [PATCH v3 08/25] python/aqmp: add logging to AsyncProtocol John Snow
2021-08-17 19:18 ` Eric Blake
2021-08-03 18:29 ` [PATCH v3 09/25] python/aqmp: add AsyncProtocol.accept() method John Snow
2021-08-17 19:29 ` Eric Blake
2021-08-18 14:24 ` John Snow
2021-08-19 14:50 ` Eric Blake
2021-08-19 15:48 ` John Snow
2021-08-19 16:43 ` Eduardo Habkost
2021-08-03 18:29 ` [PATCH v3 10/25] python/aqmp: add configurable read buffer limit John Snow
2021-08-17 19:30 ` Eric Blake
2021-08-03 18:29 ` [PATCH v3 11/25] python/aqmp: add _cb_inbound and _cb_outbound logging hooks John Snow
2021-08-17 19:32 ` Eric Blake
2021-08-03 18:29 ` [PATCH v3 12/25] python/aqmp: add AsyncProtocol._readline() method John Snow
2021-08-17 19:36 ` Eric Blake
2021-08-03 18:29 ` [PATCH v3 13/25] python/aqmp: add QMP Message format John Snow
2021-08-17 19:47 ` Eric Blake
2021-08-18 14:31 ` John Snow
2021-08-03 18:29 ` [PATCH v3 14/25] python/aqmp: add well-known QMP object models John Snow
2021-08-03 18:29 ` [PATCH v3 15/25] python/aqmp: add QMP event support John Snow
2021-08-03 18:29 ` [PATCH v3 16/25] python/pylint: disable too-many-function-args John Snow
2021-08-03 18:29 ` [PATCH v3 17/25] python/aqmp: add QMP protocol support John Snow
2021-08-03 18:29 ` [PATCH v3 18/25] python/pylint: disable no-member check John Snow
2021-08-03 18:29 ` [PATCH v3 19/25] python/aqmp: Add message routing to QMP protocol John Snow
2021-08-03 18:29 ` [PATCH v3 20/25] python/aqmp: add execute() interfaces John Snow
2021-08-03 18:29 ` John Snow [this message]
2021-08-03 18:29 ` [PATCH v3 22/25] python/aqmp: add asyncio_run compatibility wrapper John Snow
2021-08-03 18:29 ` [PATCH v3 23/25] python/aqmp: add scary message John Snow
2021-08-03 18:29 ` [PATCH v3 24/25] python: bump avocado to v90.0 John Snow
2021-08-03 18:29 ` [PATCH v3 25/25] python/aqmp: add AsyncProtocol unit tests John Snow
2021-08-04 18:41 ` John Snow
2021-08-16 21:44 ` [PATCH v3 00/25] python: introduce Asynchronous QMP package John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803182941.504537-22-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=niteesh.gs@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).