From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Auger Eric" <eric.auger@redhat.com>,
"Willian Rampazzo" <wrampazz@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Beraldo Leal" <bleal@redhat.com>
Subject: [PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()
Date: Tue, 3 Aug 2021 15:34:46 -0400 [thread overview]
Message-ID: <20210803193447.3946219-2-crosa@redhat.com> (raw)
In-Reply-To: <20210803193447.3946219-1-crosa@redhat.com>
The avocado.Test class, used as the basis of the avocado_qemu.Test
class, performs a clean of temporary directories up as part of its own
tearDown() implementation.
But the avocado_qemu.Test class is currently missing the same clean
up, as it implemented its own tearDown() method without resorting to
the upper class behavior.
This brings avocado_qemu.Test behavior in sync with the standard
avocado.Test behavior and prevents temporary directories from
cluttering the test results directory (unless instructed to do so with
Avocado's "--keep-tmp" option).
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
tests/acceptance/avocado_qemu/__init__.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index 2c4fef3e14..1e807e2e55 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -276,6 +276,7 @@ def tearDown(self):
for vm in self._vms.values():
vm.shutdown()
self._sd = None
+ super(Test, self).tearDown()
def fetch_asset(self, name,
asset_hash=None, algorithm=None,
--
2.31.1
next prev parent reply other threads:[~2021-08-03 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 19:34 [PATCH 0/2] Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry Cleber Rosa
2021-08-03 19:34 ` Cleber Rosa [this message]
2021-08-03 20:07 ` [PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown() Willian Rampazzo
2021-08-16 18:16 ` Wainer dos Santos Moschetta
2021-08-03 19:34 ` [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file Cleber Rosa
2021-08-03 20:09 ` Willian Rampazzo
2021-08-04 9:45 ` Philippe Mathieu-Daudé
2021-08-04 13:49 ` Willian Rampazzo
2021-08-16 17:59 ` Wainer dos Santos Moschetta
2021-09-01 13:49 ` Thomas Huth
2021-09-20 13:58 ` [PATCH 0/2] Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry Peter Maydell
2021-09-20 15:40 ` Willian Rampazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803193447.3946219-2-crosa@redhat.com \
--to=crosa@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).