From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH v2 02/11] chardev/socket: print a more correct command-line address
Date: Wed, 4 Aug 2021 19:48:39 +0400 [thread overview]
Message-ID: <20210804154848.557328-3-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20210804154848.557328-1-marcandre.lureau@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Better reflect the command line version of the socket address arguments,
following the now recommended long-form opt=on syntax.
Complement/fixes commit 9d902d51 "chardev: do not use short form boolean
options in non-QemuOpts character device descriptions".
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
chardev/char-socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index d0fb545963..c43668cc15 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -468,9 +468,9 @@ static char *qemu_chr_socket_address(SocketChardev *s, const char *prefix)
#ifdef CONFIG_LINUX
if (sa->has_abstract && sa->abstract) {
- abstract = ",abstract";
+ abstract = ",abstract=on";
if (sa->has_tight && sa->tight) {
- tight = ",tight";
+ tight = ",tight=on";
}
}
#endif
--
2.32.0.264.g75ae10bc75
next prev parent reply other threads:[~2021-08-04 17:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 15:48 [PATCH v2 00/11] chardev related fixes marcandre.lureau
2021-08-04 15:48 ` [PATCH v2 01/11] util: fix abstract socket path copy marcandre.lureau
2021-08-04 15:48 ` marcandre.lureau [this message]
2021-08-05 10:29 ` [PATCH v2 02/11] chardev/socket: print a more correct command-line address Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 03/11] chardev: remove needless class method marcandre.lureau
2021-08-04 15:48 ` [PATCH v2 04/11] chardev: add some comments about the class methods marcandre.lureau
2021-08-04 15:48 ` [PATCH v2 05/11] chardev: mark explicitly first argument as poisoned marcandre.lureau
2021-08-05 10:36 ` Daniel P. Berrangé
2021-08-05 10:39 ` Marc-André Lureau
2021-08-05 10:43 ` Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 06/11] chardev: fix fd_chr_add_watch() when in != out marcandre.lureau
2021-08-05 10:38 ` Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 07/11] chardev: fix qemu_chr_open_fd() being called with fd=-1 marcandre.lureau
2021-08-05 10:39 ` Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 08/11] chardev: fix qemu_chr_open_fd() with fd_in==fd_out marcandre.lureau
2021-08-05 10:40 ` Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 09/11] chardev: give some context on chardev-add error marcandre.lureau
2021-08-04 15:48 ` [PATCH v2 10/11] chardev: report a simpler error about duplicated id marcandre.lureau
2021-08-05 10:41 ` Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 11/11] chardev: reuse qmp_chardev_new() marcandre.lureau
2021-08-05 10:42 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804154848.557328-3-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).