From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 590D4C4338F for ; Fri, 6 Aug 2021 11:02:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B791A61181 for ; Fri, 6 Aug 2021 11:02:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B791A61181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:55002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBxcr-0007wp-BU for qemu-devel@archiver.kernel.org; Fri, 06 Aug 2021 07:02:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBxbL-0006uV-8U for qemu-devel@nongnu.org; Fri, 06 Aug 2021 07:01:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBxbI-0003PN-2r for qemu-devel@nongnu.org; Fri, 06 Aug 2021 07:01:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628247674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qM7aaQ+H+UnznKIzheDvdhRXYYG3kiJ/JMi0PZfg7S4=; b=NXGg6nbcKuKfoc0/8YA2OJu43YjWI0RxJebSyKNlNHpPEEQxCRWwgvuFZM0c62j9vS8PYq MlGFnBp5S5jFEWST3DzQgOz3/nhHJFpuPQn0OJ9FPCNnBrksxPsemDWk/r1pQDwgHW8OTO UiJ5LJf66QZEbY+x8DAawOxJxHlpiFI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-1MKPEReOPA686oC5mb5OGQ-1; Fri, 06 Aug 2021 07:01:13 -0400 X-MC-Unique: 1MKPEReOPA686oC5mb5OGQ-1 Received: by mail-wr1-f69.google.com with SMTP id w1-20020adf8bc10000b0290154bed98988so1730080wra.1 for ; Fri, 06 Aug 2021 04:01:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qM7aaQ+H+UnznKIzheDvdhRXYYG3kiJ/JMi0PZfg7S4=; b=hxU6zDXvOEacudJ7x/u827UMmlDM34q7W9uFMHQdV5MouGjIVTtjjy/5AZIusM+Pnb AqOfOkeuAo/sp7z/+FASy78bWnfabp1moj/+Fc9lIYuCmAQX/TDAqo9mypLz9P7ZPMyp ScdTQ3k8Km0km/opp8v4BhSVZACaAQ5n53/8d8A5F5queS3r2IkgCr5Jor3l474BA86Q v1qdKER5+/QG6gwGiH5KqCQrBDVNFGHd8Y5FtDdYFGO+S8+s4Xbhnpe+Zr12mSp29QwU 4azD9jGJXYp4+zMvreeO6BJnStF81lI21jPhfK2ts5q+4aWQMh0+GYVXnFqWkNMC49ex 3vgw== X-Gm-Message-State: AOAM531CFALTJk6K8lqsZq45oThweE8CRwUsTvdtj6xEOxno9CubNg+x /xb10o76V+ps5I8ORAsTLk9KtGabQYlfupQoD20ld5OxjhDi2svBHz2dE+k26pUX3slpma+/eOm KAPNPHVYRi6trytE= X-Received: by 2002:a1c:23d2:: with SMTP id j201mr1992933wmj.4.1628247672117; Fri, 06 Aug 2021 04:01:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmckNtDtK/HNjnDY+H/QYsDVGDIpKdEQa7fVP7yynUmbXZcjTcDPnUUZBH00HHi2WEiWU4fA== X-Received: by 2002:a1c:23d2:: with SMTP id j201mr1992918wmj.4.1628247671965; Fri, 06 Aug 2021 04:01:11 -0700 (PDT) Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id e3sm9290662wrw.51.2021.08.06.04.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 04:01:11 -0700 (PDT) Date: Fri, 6 Aug 2021 13:01:10 +0200 From: Igor Mammedov To: Eduardo Habkost Subject: Re: [PATCH for-6.2 6/6] Use PCI_HOST_BRIDGE macro Message-ID: <20210806130110.73e6f40c@redhat.com> In-Reply-To: <20210805193431.307761-7-ehabkost@redhat.com> References: <20210805193431.307761-1-ehabkost@redhat.com> <20210805193431.307761-7-ehabkost@redhat.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson , qemu-devel@nongnu.org, "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 5 Aug 2021 15:34:31 -0400 Eduardo Habkost wrote: > OBJECT_CHECK(PciHostState, ..., TYPE_PCI_HOST_BRIDGE) is exactly > what the PCI_HOST_BRIDGE macro does. We can just use the macro > instead of using OBJECT_CHECK manually. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > Cc: qemu-devel@nongnu.org > --- > hw/i386/acpi-build.c | 8 ++------ > hw/pci-host/i440fx.c | 4 +--- > 2 files changed, 3 insertions(+), 9 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index a33ac8b91e1..3c6bbb1beb3 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -303,13 +303,9 @@ Object *acpi_get_i386_pci_host(void) > { > PCIHostState *host; > > - host = OBJECT_CHECK(PCIHostState, > - object_resolve_path("/machine/i440fx", NULL), > - TYPE_PCI_HOST_BRIDGE); > + host = PCI_HOST_BRIDGE(object_resolve_path("/machine/i440fx", NULL)); > if (!host) { > - host = OBJECT_CHECK(PCIHostState, > - object_resolve_path("/machine/q35", NULL), > - TYPE_PCI_HOST_BRIDGE); > + host = PCI_HOST_BRIDGE(object_resolve_path("/machine/q35", NULL)); > } > return OBJECT(host); > diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c > index 28c9bae8994..cd87e21a9b2 100644 > --- a/hw/pci-host/i440fx.c > +++ b/hw/pci-host/i440fx.c > @@ -316,9 +316,7 @@ PCIBus *i440fx_init(const char *host_type, const char *pci_type, > > PCIBus *find_i440fx(void) > { > - PCIHostState *s = OBJECT_CHECK(PCIHostState, > - object_resolve_path("/machine/i440fx", NULL), > - TYPE_PCI_HOST_BRIDGE); > + PCIHostState *s = PCI_HOST_BRIDGE(object_resolve_path("/machine/i440fx", NULL)); > return s ? s->bus : NULL; > } >