From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA520C4338F for ; Fri, 6 Aug 2021 19:40:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 432B561167 for ; Fri, 6 Aug 2021 19:40:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 432B561167 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mC5i7-00074X-WF for qemu-devel@archiver.kernel.org; Fri, 06 Aug 2021 15:40:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC5h6-0006Eg-Cu for qemu-devel@nongnu.org; Fri, 06 Aug 2021 15:39:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57211) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC5h3-0007Yy-Fz for qemu-devel@nongnu.org; Fri, 06 Aug 2021 15:39:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628278784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MbK+RxACVOkfS1LDqyVncEW3oyFfuFp1qf5kdTpJZhg=; b=NDd1uYADrWRvfk/ivnSy/NZjk4LwAu8Q7dxuRzMun7vm9DCdHo73wwK9W3CajLem4zMl67 wz5yWDKTWI7IRs1LPBwcDp9z3nGpgB0JX3Vzs6s7ZMoLSHDdc8flzLdS8I/3m9pHmuuQQR 1GK0JDmp5Q+DoWS8ledU4qaskEwE+S0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-yi5AxXmmPFW5Ywyj5l_muQ-1; Fri, 06 Aug 2021 15:39:42 -0400 X-MC-Unique: yi5AxXmmPFW5Ywyj5l_muQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 440FF107ACF5; Fri, 6 Aug 2021 19:39:41 +0000 (UTC) Received: from redhat.com (ovpn-112-138.phx2.redhat.com [10.3.112.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 625EA1036D06; Fri, 6 Aug 2021 19:39:40 +0000 (UTC) Date: Fri, 6 Aug 2021 14:39:38 -0500 From: Eric Blake To: Max Reitz Subject: Re: [PATCH for-6.2 v3 05/12] job: @force parameter for job_cancel_sync{, _all}() Message-ID: <20210806193938.blsklchugkfbz27i@redhat.com> References: <20210806093859.706464-1-mreitz@redhat.com> <20210806093859.706464-6-mreitz@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210806093859.706464-6-mreitz@redhat.com> User-Agent: NeoMutt/20210205-687-0ed190 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Aug 06, 2021 at 11:38:52AM +0200, Max Reitz wrote: > Callers should be able to specify whether they want job_cancel_sync() to > force-cancel the job or not. > > In fact, almost all invocations do not care about consistency of the > result and just want the job to terminate as soon as possible, so they > should pass force=true. The replication block driver is the exception. > > This changes some iotest outputs, because quitting qemu while a mirror > job is active will now lead to it being cancelled instead of completed, > which is what we want. (Cancelling a READY mirror job with force=false > may take an indefinite amount of time, which we do not want when > quitting. If users want consistent results, they must have all jobs be > done before they quit qemu.) Feels somewhat like a bug fix, but I also understand why you'd prefer to delay this to 6.2 (it is not a fresh regression, but a longstanding issue). > > Buglink: https://gitlab.com/qemu-project/qemu/-/issues/462 > Signed-off-by: Max Reitz > --- > +++ b/job.c > @@ -982,12 +982,24 @@ static void job_cancel_err(Job *job, Error **errp) > job_cancel(job, false); > } > > -int job_cancel_sync(Job *job) > +/** > + * Same as job_cancel_err(), but force-cancel. > + */ > +static void job_force_cancel_err(Job *job, Error **errp) > { > - return job_finish_sync(job, &job_cancel_err, NULL); > + job_cancel(job, true); > +} In isolation, it looks odd that errp is passed but not used. But looking further, it's because this is a callback that must have a given signature, so it's okay. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org