From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332BBC4338F for ; Fri, 6 Aug 2021 21:10:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8711D60243 for ; Fri, 6 Aug 2021 21:10:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8711D60243 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:52810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mC76a-0005EA-Ir for qemu-devel@archiver.kernel.org; Fri, 06 Aug 2021 17:10:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC75g-0003bc-LT for qemu-devel@nongnu.org; Fri, 06 Aug 2021 17:09:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33529) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC75d-00021R-6g for qemu-devel@nongnu.org; Fri, 06 Aug 2021 17:09:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628284151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GpI8dLRllKqerPfjZVbAq4lrZsrCcsHlxELs2hpWlGE=; b=b+kj8KplBuB1T3z+dWRoXQ7xWWUmKXy5WDuDcRPldtPS7PY1ZEUt6N3HjDnDyQjiycpP13 nQm5Zvbv2TJYq9bSjhwCoTJTGZ77F6F8CqWOfz5A6+drzUrxgXJ46M3UyCUXmth65LyiMQ 8e3cyL3wU8ozC6ITjXfpV1fQHTX58P4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-tJOHOAtONDyzZ0LXiV30mA-1; Fri, 06 Aug 2021 17:09:09 -0400 X-MC-Unique: tJOHOAtONDyzZ0LXiV30mA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36CF3760C8 for ; Fri, 6 Aug 2021 21:09:08 +0000 (UTC) Received: from redhat.com (ovpn-112-138.phx2.redhat.com [10.3.112.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 386B75D9D5; Fri, 6 Aug 2021 21:09:04 +0000 (UTC) Date: Fri, 6 Aug 2021 16:09:02 -0500 From: Eric Blake To: Markus Armbruster Subject: Re: [PATCH] qapi: Fix crash on redefinition with a different condition Message-ID: <20210806210902.gorp6sd3suhg4ihe@redhat.com> References: <20210806120510.2367124-1-armbru@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210806120510.2367124-1-armbru@redhat.com> User-Agent: NeoMutt/20210205-687-0ed190 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Aug 06, 2021 at 02:05:10PM +0200, Markus Armbruster wrote: > QAPISchema._make_implicit_object_type() asserts that when an implicit > object type is used multiple times, @ifcond is the same for all uses. > It will be for legitimate uses, i.e. simple union branch wrapper > types. A comment explains this. > > The assertion fails when a command or event is redefined with a > different condition. The redefinition is an error, but it's flagged > only later. > > Fixing the assertion would complicate matters further. Not > worthwhile, drop it instead. We really need to get rid of simple > unions. > > Tweak test case redefined-event to cover redefinition with a different > condition. > > Signed-off-by: Markus Armbruster > --- 6.2 material (this corner case doesn't fire in our 6.1 code base, and really only matters for developers adding new interfaces which won't happen in 6.1). Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org