From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4BBEC4338F for ; Fri, 6 Aug 2021 21:20:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19E3460E78 for ; Fri, 6 Aug 2021 21:20:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 19E3460E78 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:33268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mC7Gw-0004oI-Q0 for qemu-devel@archiver.kernel.org; Fri, 06 Aug 2021 17:20:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC7Fg-00022z-Hz for qemu-devel@nongnu.org; Fri, 06 Aug 2021 17:19:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC7Fe-0000hW-Nb for qemu-devel@nongnu.org; Fri, 06 Aug 2021 17:19:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628284774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PGYgUoE80BzRpCI9195mDYQv6izVDMVZcK79Z9DVZDo=; b=DwEB0YD85JctRPmNB0YFAjRQV7/O3olMqU9mpO5iKatCMmdOK9rciXLdKmxHTqD3GFqxDU pQLGQOq20zPCDheg8lfRKDktXZL4p9EKaOaLgFb6xJXTEf8aem0ZUbDL5OYshsLV6tx2kb eHoHwKBxADR/Xxa+l48xS7LFSEdYYDY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-xSN_i7BvNnCBUIghIxnhpQ-1; Fri, 06 Aug 2021 17:19:31 -0400 X-MC-Unique: xSN_i7BvNnCBUIghIxnhpQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D0DB190B2A0; Fri, 6 Aug 2021 21:19:30 +0000 (UTC) Received: from redhat.com (ovpn-112-138.phx2.redhat.com [10.3.112.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9E59019CBA; Fri, 6 Aug 2021 21:19:29 +0000 (UTC) Date: Fri, 6 Aug 2021 16:19:27 -0500 From: Eric Blake To: Vladislav Yaroshchuk Subject: Re: [PATCH 2/7] net/vmnet: add new netdevs to qapi/net Message-ID: <20210806211927.dvsn7xvy2ghmonip@redhat.com> References: <20210617143246.55336-1-yaroshchuk2000@gmail.com> <20210617143246.55336-3-yaroshchuk2000@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210617143246.55336-3-yaroshchuk2000@gmail.com> User-Agent: NeoMutt/20210205-687-0ed190 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jasowang@redhat.com, r.bolshakov@yadro.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 17, 2021 at 05:32:41PM +0300, Vladislav Yaroshchuk wrote: > Created separate netdev per each vmnet operating mode > because they use quite different settings. Especially since > macOS 11.0 (vmnet.framework API gets lots of updates) > > Three new netdevs are added: > - vmnet-host > - vmnet-shared > - vmnet-bridged > > Signed-off-by: Vladislav Yaroshchuk > --- > +++ b/qapi/net.json > @@ -452,6 +452,89 @@ > '*vhostdev': 'str', > '*queues': 'int' } } > > +## > +# @NetdevVmnetHostOptions: > +# > +# vmnet (host mode) network backend. > +# > +# Allows the vmnet interface to communicate with > +# other vmnet interfaces that are in host mode and also with the native host. > +# > +# @dhcpstart: The starting IPv4 address to use for the interface. Must be in the > +# private IP range (RFC 1918). Must be specified along > +# with @dhcpend and @subnetmask. > +# This address is used as the gateway address. The subsequent address > +# up to and including dhcpend are placed in the DHCP pool. > +# > +# @dhcpend: The DHCP IPv4 range end address to use for the interface. Must be in > +# the private IP range (RFC 1918). Must be specified along > +# with @dhcpstart and @subnetmask. > +# > +# @subnetmask: The IPv4 subnet mask to use on the interface. Must be specified > +# along with @dhcpstart and @subnetmask. > +# > +# > +# Since: 6.1, > +## Same comments about 6.1 vs. 6.2 as before (I'll quit pointing it out). Spurious trailing comma. > +{ 'struct': 'NetdevVmnetHostOptions', > + 'data': { > + '*dhcpstart': 'str', > + '*dhcpend': 'str', > + '*subnetmask': 'str' Hmm. You listed all three as optional, but document that they must all be specified together. Why not just make them all required, and simplify the documentation? > + }, > + 'if': 'defined(CONFIG_VMNET)' } > + > +## > +# @NetdevVmnetSharedOptions: > +# > +# vmnet (shared mode) network backend. > +# > +# Allows traffic originating from the vmnet interface to reach the > +# Internet through a network address translator (NAT). The vmnet interface > +# can also communicate with the native host. By default, the vmnet interface > +# is able to communicate with other shared mode interfaces. If a subnet range > +# is specified, the vmnet interface can communicate with other shared mode > +# interfaces on the same subnet. > +# > +# @dhcpstart: The starting IPv4 address to use for the interface. Must be in the > +# private IP range (RFC 1918). Must be specified along > +# with @dhcpend and @subnetmask. > +# This address is used as the gateway address. The subsequent address > +# up to and including dhcpend are placed in the DHCP pool. Spurious double space. > +# > +# @dhcpend: The DHCP IPv4 range end address to use for the interface. Must be in > +# the private IP range (RFC 1918). Must be specified along > +# with @dhcpstart and @subnetmask. > +# > +# @subnetmask: The IPv4 subnet mask to use on the interface. Must be specified > +# along with @dhcpstart and @subnetmask. > +# > +# > +# Since: 6.1, > +## > +{ 'struct': 'NetdevVmnetSharedOptions', > + 'data': { > + '*dhcpstart': 'str', > + '*dhcpend': 'str', > + '*subnetmask': 'str' > + }, > + 'if': 'defined(CONFIG_VMNET)' } > + > +## > +# @NetdevVmnetBridgedOptions: > +# > +# vmnet (bridged mode) network backend. > +# > +# Bridges the vmnet interface with a physical network interface. > +# > +# @ifname: The name of the physical interface to be bridged. > +# > +# Since: 6.1 > +## > +{ 'struct': 'NetdevVmnetBridgedOptions', > + 'data': { 'ifname': 'str' }, > + 'if': 'defined(CONFIG_VMNET)' } > + > ## > # @NetClientDriver: > # > @@ -460,11 +543,16 @@ > # Since: 2.7 > # > # @vhost-vdpa since 5.1 > -# @vmnet since 6.1 Why are you dropping vmnet? Especially since you just added it in the previous patch? That feels like needless churn. > +# @vmnet-host since 6.1 > +# @vmnet-shared since 6.1 > +# @vmnet-bridged since 6.1 > ## > { 'enum': 'NetClientDriver', > 'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde', > - 'bridge', 'hubport', 'netmap', 'vhost-user', 'vhost-vdpa', 'vmnet' ] } > + 'bridge', 'hubport', 'netmap', 'vhost-user', 'vhost-vdpa', > + { 'name': 'vmnet-host', 'if': 'defined(CONFIG_VMNET)' }, > + { 'name': 'vmnet-shared', 'if': 'defined(CONFIG_VMNET)' }, > + { 'name': 'vmnet-bridged', 'if': 'defined(CONFIG_VMNET)' }] } -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org