* Re: [PATCH] hw/riscv: virt: Move flash node to root
2021-08-07 3:56 [PATCH] hw/riscv: virt: Move flash node to root Bin Meng
@ 2021-08-07 8:18 ` Philippe Mathieu-Daudé
2021-08-07 23:22 ` Alistair Francis
2021-08-09 1:03 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-08-07 8:18 UTC (permalink / raw)
To: Bin Meng, Alistair Francis, qemu-devel, qemu-riscv
On 8/7/21 5:56 AM, Bin Meng wrote:
> The flash is not inside the SoC, so it's inappropriate to put it
> under the /soc node. Move it to root instead.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> hw/riscv/virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index 4a3cd2599a..89fb607c47 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -455,7 +455,7 @@ static void create_fdt(RISCVVirtState *s, const MemMapEntry *memmap,
> qemu_fdt_setprop_cell(fdt, name, "interrupts", RTC_IRQ);
> g_free(name);
>
> - name = g_strdup_printf("/soc/flash@%" PRIx64, flashbase);
> + name = g_strdup_printf("/flash@%" PRIx64, flashbase);
> qemu_fdt_add_subnode(mc->fdt, name);
> qemu_fdt_setprop_string(mc->fdt, name, "compatible", "cfi-flash");
> qemu_fdt_setprop_sized_cells(mc->fdt, name, "reg",
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hw/riscv: virt: Move flash node to root
2021-08-07 3:56 [PATCH] hw/riscv: virt: Move flash node to root Bin Meng
2021-08-07 8:18 ` Philippe Mathieu-Daudé
@ 2021-08-07 23:22 ` Alistair Francis
2021-08-09 1:03 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2021-08-07 23:22 UTC (permalink / raw)
To: Bin Meng
Cc: open list:RISC-V, Alistair Francis,
qemu-devel@nongnu.org Developers
On Sat, Aug 7, 2021 at 1:57 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The flash is not inside the SoC, so it's inappropriate to put it
> under the /soc node. Move it to root instead.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> hw/riscv/virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index 4a3cd2599a..89fb607c47 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -455,7 +455,7 @@ static void create_fdt(RISCVVirtState *s, const MemMapEntry *memmap,
> qemu_fdt_setprop_cell(fdt, name, "interrupts", RTC_IRQ);
> g_free(name);
>
> - name = g_strdup_printf("/soc/flash@%" PRIx64, flashbase);
> + name = g_strdup_printf("/flash@%" PRIx64, flashbase);
> qemu_fdt_add_subnode(mc->fdt, name);
> qemu_fdt_setprop_string(mc->fdt, name, "compatible", "cfi-flash");
> qemu_fdt_setprop_sized_cells(mc->fdt, name, "reg",
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hw/riscv: virt: Move flash node to root
2021-08-07 3:56 [PATCH] hw/riscv: virt: Move flash node to root Bin Meng
2021-08-07 8:18 ` Philippe Mathieu-Daudé
2021-08-07 23:22 ` Alistair Francis
@ 2021-08-09 1:03 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2021-08-09 1:03 UTC (permalink / raw)
To: Bin Meng
Cc: open list:RISC-V, Alistair Francis,
qemu-devel@nongnu.org Developers
On Sat, Aug 7, 2021 at 1:57 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The flash is not inside the SoC, so it's inappropriate to put it
> under the /soc node. Move it to root instead.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
>
> hw/riscv/virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index 4a3cd2599a..89fb607c47 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -455,7 +455,7 @@ static void create_fdt(RISCVVirtState *s, const MemMapEntry *memmap,
> qemu_fdt_setprop_cell(fdt, name, "interrupts", RTC_IRQ);
> g_free(name);
>
> - name = g_strdup_printf("/soc/flash@%" PRIx64, flashbase);
> + name = g_strdup_printf("/flash@%" PRIx64, flashbase);
> qemu_fdt_add_subnode(mc->fdt, name);
> qemu_fdt_setprop_string(mc->fdt, name, "compatible", "cfi-flash");
> qemu_fdt_setprop_sized_cells(mc->fdt, name, "reg",
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread