From: Gerd Hoffmann <kraxel@redhat.com>
To: "Volker Rümelin" <vr_qemu@t-online.de>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] ps2: use a separate keyboard command reply queue
Date: Mon, 9 Aug 2021 11:52:07 +0200 [thread overview]
Message-ID: <20210809095207.w4ps4zusyreqrrlc@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210807121202.6294-2-vr_qemu@t-online.de>
Hi,
> A PS/2 keyboard has a separate command reply queue that is
> independant of the key queue. This prevents that command replies
> and keyboard input mix. Keyboard command replies take precedence
> over queued keystrokes. A new keyboard command removes any
> remaining command replies from the command reply queue.
>
> Implement a separate keyboard command reply queue and clear the
> command reply queue before command execution. This brings the
> PS/2 keyboard emulation much closer to a real PS/2 keyboard.
It seems you place both queues in the existing 256-byte buffer,
probably to avoid breaking live migration.
Could you explain the logic a bit more, how the three pointers q->*ptr
variables play together here?
thanks,
Gerd
next prev parent reply other threads:[~2021-08-09 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 12:10 ps2: Fix issue #501 and #502 Volker Rümelin
2021-08-07 12:12 ` [PATCH 1/3] ps2: use the whole ps2 buffer but keep queue size Volker Rümelin
2021-08-07 12:12 ` [PATCH 2/3] ps2: use a separate keyboard command reply queue Volker Rümelin
2021-08-09 9:52 ` Gerd Hoffmann [this message]
2021-08-07 12:12 ` [PATCH 3/3] ps2: migration support for " Volker Rümelin
2021-08-09 10:18 ` Gerd Hoffmann
2021-08-10 5:05 ` Volker Rümelin
2021-08-10 5:40 ` Gerd Hoffmann
2021-08-10 8:38 ` Volker Rümelin
2021-08-07 14:29 ` [PATCH-for-6.1? 0/3] ps2: Fix issue #501 and #502 Philippe Mathieu-Daudé
2021-08-10 9:07 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210809095207.w4ps4zusyreqrrlc@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).