From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Coiby Xu <coiby.xu@gmail.com>
Cc: peter.maydell@linaro.org, qemu-block@nongnu.org,
philmd@redhat.com, alxndr@bu.edu,
Stefan Hajnoczi <stefanha@redhat.com>,
alex.bennee@linaro.org
Subject: [PATCH] tests/qtest/vhost-user-blk-test: Check whether qemu-storage-daemon is available
Date: Wed, 11 Aug 2021 11:59:49 +0200 [thread overview]
Message-ID: <20210811095949.133462-1-thuth@redhat.com> (raw)
The vhost-user-blk-test currently hangs if QTEST_QEMU_STORAGE_DAEMON_BINARY
points to a non-existing binary. Let's improve this situation by checking
for the availability of the binary first, so we can fail gracefully if
it is not accessible.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/vhost-user-blk-test.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tests/qtest/vhost-user-blk-test.c b/tests/qtest/vhost-user-blk-test.c
index 8796c74ca4..6f108a1b62 100644
--- a/tests/qtest/vhost-user-blk-test.c
+++ b/tests/qtest/vhost-user-blk-test.c
@@ -789,6 +789,14 @@ static const char *qtest_qemu_storage_daemon_binary(void)
exit(0);
}
+ /* If we've got a path to the binary, check whether we can access it */
+ if (strchr(qemu_storage_daemon_bin, '/') &&
+ access(qemu_storage_daemon_bin, X_OK) != 0) {
+ fprintf(stderr, "ERROR: '%s' is not accessible\n",
+ qemu_storage_daemon_bin);
+ exit(1);
+ }
+
return qemu_storage_daemon_bin;
}
--
2.27.0
next reply other threads:[~2021-08-11 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 9:59 Thomas Huth [this message]
2021-08-11 10:10 ` [PATCH] tests/qtest/vhost-user-blk-test: Check whether qemu-storage-daemon is available Alexander Bulekov
2021-08-11 11:08 ` Peter Maydell
2021-10-14 6:45 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811095949.133462-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alxndr@bu.edu \
--cc=coiby.xu@gmail.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).