From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, eblake@redhat.com, philmd@redhat.com
Subject: [PATCH] configure: Remove spurious [] from tr
Date: Thu, 12 Aug 2021 12:09:42 +0100 [thread overview]
Message-ID: <20210812110942.19065-1-dgilbert@redhat.com> (raw)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
ShellCheck points out that tr '[a-z]' actually replaces the []'s
and only the a-z is needed.
Remove the spurious [] - although in this use it will make no
difference.
Fixes: bb55b712e8dc4d4eb515144d5c26798fea178cba
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 9a79a004d7..5bb8c2a59d 100755
--- a/configure
+++ b/configure
@@ -4549,7 +4549,7 @@ if test "$gprof" = "yes" ; then
fi
echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
for drv in $audio_drv_list; do
- def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr '[a-z]' '[A-Z]')
+ def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr 'a-z' 'A-Z')
echo "$def=y" >> $config_host_mak
done
if test "$alsa" = "yes" ; then
--
2.31.1
next reply other threads:[~2021-08-12 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 11:09 Dr. David Alan Gilbert (git) [this message]
2021-08-12 11:58 ` [PATCH] configure: Remove spurious [] from tr Peter Maydell
2021-08-12 13:05 ` Dr. David Alan Gilbert
2021-08-12 13:54 ` Eric Blake
2021-08-12 17:51 ` Paolo Bonzini
2021-08-12 17:49 ` Paolo Bonzini
2021-08-12 17:54 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812110942.19065-1-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).