From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: [PULL 03/11] storage-daemon: Add missing build dependency to the vhost-user-blk-test
Date: Sat, 14 Aug 2021 08:09:48 +0200 [thread overview]
Message-ID: <20210814060956.12852-4-thuth@redhat.com> (raw)
In-Reply-To: <20210814060956.12852-1-thuth@redhat.com>
vhost-user-blk-test needs the qemu-storage-daemon, otherwise it
currently hangs. So make sure that we build the daemon before running
the tests.
Message-Id: <20210811094705.131314-1-thuth@redhat.com>
Tested-by: Alexander Bulekov <alxndr@bu.edu>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
storage-daemon/meson.build | 8 ++++----
tests/qtest/meson.build | 7 +++++--
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/storage-daemon/meson.build b/storage-daemon/meson.build
index 68852f3d25..49c9d2eac9 100644
--- a/storage-daemon/meson.build
+++ b/storage-daemon/meson.build
@@ -6,8 +6,8 @@ subdir('qapi')
if have_tools
qsd_ss = qsd_ss.apply(config_host, strict: false)
- executable('qemu-storage-daemon',
- qsd_ss.sources(),
- dependencies: qsd_ss.dependencies(),
- install: true)
+ qsd = executable('qemu-storage-daemon',
+ qsd_ss.sources(),
+ dependencies: qsd_ss.dependencies(),
+ install: true)
endif
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index e22a0792c5..2bc3efd49f 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -276,8 +276,11 @@ foreach dir : target_dirs
endif
qtest_env.set('G_TEST_DBUS_DAEMON', meson.source_root() / 'tests/dbus-vmstate-daemon.sh')
qtest_env.set('QTEST_QEMU_BINARY', './qemu-system-' + target_base)
- qtest_env.set('QTEST_QEMU_STORAGE_DAEMON_BINARY', './storage-daemon/qemu-storage-daemon')
-
+ if have_tools and have_vhost_user_blk_server
+ qtest_env.set('QTEST_QEMU_STORAGE_DAEMON_BINARY', './storage-daemon/qemu-storage-daemon')
+ test_deps += [qsd]
+ endif
+
foreach test : target_qtests
# Executables are shared across targets, declare them only the first time we
# encounter them
--
2.27.0
next prev parent reply other threads:[~2021-08-14 6:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 6:09 [PULL 00/11] Optional gitlab-CI and doc fixes for -rc4 Thomas Huth
2021-08-14 6:09 ` [PULL 01/11] gitlab: exclude sparc-softmmu and riscv32-softmmu from cross builds Thomas Huth
2021-08-14 6:09 ` [PULL 02/11] gitlab: skip many more targets in windows " Thomas Huth
2021-08-15 15:47 ` Peter Maydell
2021-08-14 6:09 ` Thomas Huth [this message]
2021-08-14 6:09 ` [PULL 04/11] tests/qtest/vhost-user-blk-test: Check whether qemu-storage-daemon is available Thomas Huth
2021-08-14 6:09 ` [PULL 05/11] fuzz: avoid building twice, when running on gitlab Thomas Huth
2021-08-14 6:09 ` [PULL 06/11] docs/about/removed-features: Document removed CLI options from QEMU v2.12 Thomas Huth
2021-08-14 6:09 ` [PULL 07/11] docs/about/removed-features: Document removed CLI options from QEMU v3.0 Thomas Huth
2021-08-14 6:09 ` [PULL 08/11] docs/about/removed-features: Document removed CLI options from QEMU v3.1 Thomas Huth
2021-08-14 6:09 ` [PULL 09/11] docs/about/removed-features: Document removed HMP commands from QEMU v2.12 Thomas Huth
2021-08-14 6:09 ` [PULL 10/11] docs/about/removed-features: Document removed devices from older QEMU versions Thomas Huth
2021-08-14 6:09 ` [PULL 11/11] docs/about/removed-features: Document removed machines " Thomas Huth
2021-08-16 9:01 ` [PULL 00/11] Optional gitlab-CI and doc fixes for -rc4 Peter Maydell
2021-08-16 10:22 ` Alexander Bulekov
2021-08-16 11:11 ` Daniel P. Berrangé
2021-08-16 11:30 ` Alexander Bulekov
2021-08-16 11:40 ` Philippe Mathieu-Daudé
2021-08-16 12:00 ` Alexander Bulekov
2021-08-16 11:44 ` Daniel P. Berrangé
2021-08-17 7:23 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210814060956.12852-4-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).