From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3EBFC4338F for ; Sat, 14 Aug 2021 15:47:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 233D660720 for ; Sat, 14 Aug 2021 15:47:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 233D660720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEvsL-0004ow-1A for qemu-devel@archiver.kernel.org; Sat, 14 Aug 2021 11:47:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEvrd-00049J-4D for qemu-devel@nongnu.org; Sat, 14 Aug 2021 11:46:25 -0400 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]:34741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEvrb-00054W-KO for qemu-devel@nongnu.org; Sat, 14 Aug 2021 11:46:24 -0400 Received: by mail-ot1-x331.google.com with SMTP id e13-20020a9d63cd0000b02904fa42f9d275so15786630otl.1 for ; Sat, 14 Aug 2021 08:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=GTycN65LLoVvkDr2bBP5oVEeC7fsYIAnyGRRZysG8kA=; b=o2QRFuGTlctpz2uSyyNZJRMSNggw1VEdCYoB/F7ejhaH9lRutj79WdcOiJESVTrf+Z qpTv6OUN2b96G1ek3XGgYl8WEzeGTtUf0yKhCr96Erdwyg2rxDAUr1F7FEcYg6cXBerw p1Ul9MZCWFfzMtWi5zFcNQDP0zO7DHDxnGEoeYLYFleFFV2eXmZan1qKqI7i5wsEBhoI XRwM/n6oIRpqXzCxEHzOmjhc7EeRi77Mm7jg0asWFz1VsAmMg+lKjMscB06lru9dXzvD PsnhpDnzKC1Jiim81PEGn2OBvpZQqSfMRKVsmaLQ2xM6+2SWn96GTyg7oEfywI4wiuSR yLmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=GTycN65LLoVvkDr2bBP5oVEeC7fsYIAnyGRRZysG8kA=; b=EIax7M4+NraWZVCMLiQohPo4MFQIi9kdbG2jsFcj5ZBh7BX/6mOabb2Z6jYOrQWXZK n+nBseXKYtDx613jlNp8yvPj5QJG+izGsdQv8D8zJpRen/9NYfEa4JM4kP+HftuOw+Y4 KZRH9EwS38Uvc2XmMPkmGiFy2SWXhneNHDarxvSxSSuGJP5bpEcWMqFpDPxYySJ7o4TR 5dGebYWneXRYiH787eWY24hCcwzVENXcsfdr6J5UXM3t37sl4xczhHhf/zH0Edqol67s oltEUZxhljGyb/m9l5wck3aIuJANimEYhnEqECLwtSYUbelSfb9OvB6xONyycMxRvOE+ Ohsg== X-Gm-Message-State: AOAM532InKVWkPsCgpOskFhOZz3NaD98kPIEUAkkmim9h4h9nezQfjKI HXKFWycf4acOTPkd6upj4w== X-Google-Smtp-Source: ABdhPJxkT0D7p0j+6RrxO32ai56sU3hOYQqS2wlCKdQh3vzP0Mo+3Fk05n+lMsvN9UZthLBXrnzKsQ== X-Received: by 2002:a9d:4f02:: with SMTP id d2mr6323117otl.332.1628955981730; Sat, 14 Aug 2021 08:46:21 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id z3sm935337oot.46.2021.08.14.08.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Aug 2021 08:46:20 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:3473:22de:5192:40f0]) by serve.minyard.net (Postfix) with ESMTPSA id E5455180058; Sat, 14 Aug 2021 15:46:19 +0000 (UTC) Date: Sat, 14 Aug 2021 10:46:18 -0500 From: Corey Minyard To: Peter Maydell Subject: Re: [PATCH for-6.2 3/4] tests/qtest/ipmi-bt-test: Zero-initialize sockaddr struct Message-ID: <20210814154618.GW3406@minyard.net> References: <20210813150506.7768-1-peter.maydell@linaro.org> <20210813150506.7768-4-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210813150506.7768-4-peter.maydell@linaro.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::331; envelope-from=tcminyard@gmail.com; helo=mail-ot1-x331.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: Alex =?utf-8?Q?Benn=C3=A9e?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jason Wang , Eric Blake , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Aug 13, 2021 at 04:05:05PM +0100, Peter Maydell wrote: > Zero-initialize the sockaddr_in struct that we're about to fill in > and pass to bind(), to ensure we don't leave possible > implementation-defined extension fields as uninitialized garbage. > > Signed-off-by: Peter Maydell Looks good to me. Thanks, Peter. I looked through all the other patches, too, and reviewed those. Reviewed-by: Corey Minyard > --- > tests/qtest/ipmi-bt-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qtest/ipmi-bt-test.c > index 8492f02a9c3..19612e9405a 100644 > --- a/tests/qtest/ipmi-bt-test.c > +++ b/tests/qtest/ipmi-bt-test.c > @@ -378,7 +378,7 @@ static void test_enable_irq(void) > */ > static void open_socket(void) > { > - struct sockaddr_in myaddr; > + struct sockaddr_in myaddr = {}; > socklen_t addrlen; > > myaddr.sin_family = AF_INET; > -- > 2.20.1 >