From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05218C4338F for ; Mon, 16 Aug 2021 05:06:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54082615E2 for ; Mon, 16 Aug 2021 05:06:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 54082615E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:56618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFUpr-0000eo-AM for qemu-devel@archiver.kernel.org; Mon, 16 Aug 2021 01:06:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFUp6-0008Jm-JB for qemu-devel@nongnu.org; Mon, 16 Aug 2021 01:06:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFUp2-0004YU-29 for qemu-devel@nongnu.org; Mon, 16 Aug 2021 01:06:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629090362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fLYTqfGebZitJkrv86sFkZxtNNuKJJcMrKoYU9m5fmI=; b=HLqsJgxzvx6nIKreF4acJ+FdmPD0OZRHJfT/sgfQz69+Lfs/pV837jMneggdL5NgtUooFo B3O4VRzcA0hRYyZDsVKLqgcqqqptq2h1dT5vlLMMP72CshiXlCfQYqgxZ88K4nmh5+mjab qLV9L+QhubcDK2hFjiaQuGbUQqBbYF8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397--ENLQbJ2N327N4yKLPycmA-1; Mon, 16 Aug 2021 01:05:58 -0400 X-MC-Unique: -ENLQbJ2N327N4yKLPycmA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 946B6180FCBB; Mon, 16 Aug 2021 05:05:57 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E94960854; Mon, 16 Aug 2021 05:05:57 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id AD2061800382; Mon, 16 Aug 2021 07:05:55 +0200 (CEST) Date: Mon, 16 Aug 2021 07:05:55 +0200 From: Gerd Hoffmann To: Thomas Huth Subject: Re: [PATCH] vga: don't abort when adding a duplicate isa-vga device Message-ID: <20210816050555.k63uuhqhbloarcj2@sirius.home.kraxel.org> References: <20210813233619.32178-1-jziviani@suse.de> <9dd25d6d-b9ba-0000-96a0-451fd1b28c56@redhat.com> MIME-Version: 1.0 In-Reply-To: <9dd25d6d-b9ba-0000-96a0-451fd1b28c56@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, "Jose R. Ziviani" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > > + if (qemu_ram_block_by_name("vga.vram")) { > > + error_report("vga.vram is already registered, ignoring this device"); > > + return; > > + } > > I think we should not ignore the error, but rather turn this into a proper > error (instead of aborting). Yes. Silently fixing up things automatically tends to be worse long-term. take care, Gerd