From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31083C4338F for ; Tue, 17 Aug 2021 19:37:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E34626054E for ; Tue, 17 Aug 2021 19:37:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E34626054E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mG4tY-0003lq-SD for qemu-devel@archiver.kernel.org; Tue, 17 Aug 2021 15:37:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mG4st-000346-L9 for qemu-devel@nongnu.org; Tue, 17 Aug 2021 15:36:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mG4sr-0005qu-Qg for qemu-devel@nongnu.org; Tue, 17 Aug 2021 15:36:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629228984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MEo8JzfN+KwH4WS/Odl1IoulZ9WWVs87YE43QxfZyzM=; b=DGMg7RnP/zwiXDOfN4deds100sghLFnx0fK6dJOM5qlhiTTYUlJUdsLE+qsLgBya2VgbEj dCP6KRgmPC/AOI7tOEnOYMFANd7k4pQnR7AKRuhYEVkMGhjGqNMKU+Pn8VQxz0T08FRtZQ FFqaLkmTdL429bTVWlpjEvf+Zlub324= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-4ojkpNB4PiOsYCWqyBAdvQ-1; Tue, 17 Aug 2021 15:36:21 -0400 X-MC-Unique: 4ojkpNB4PiOsYCWqyBAdvQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A31281F2DB; Tue, 17 Aug 2021 19:36:20 +0000 (UTC) Received: from redhat.com (ovpn-114-146.phx2.redhat.com [10.3.114.146]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30FFB60871; Tue, 17 Aug 2021 19:36:12 +0000 (UTC) Date: Tue, 17 Aug 2021 14:36:10 -0500 From: Eric Blake To: John Snow Subject: Re: [PATCH v3 12/25] python/aqmp: add AsyncProtocol._readline() method Message-ID: <20210817193610.3vufvbjtdgz7liej@redhat.com> References: <20210803182941.504537-1-jsnow@redhat.com> <20210803182941.504537-13-jsnow@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210803182941.504537-13-jsnow@redhat.com> User-Agent: NeoMutt/20210205-719-68949a X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Willian Rampazzo , Markus Armbruster , Wainer dos Santos Moschetta , qemu-devel@nongnu.org, "Niteesh G . S ." , Stefan Hajnoczi , Cleber Rosa , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Aug 03, 2021 at 02:29:28PM -0400, John Snow wrote: > This is added as a courtesy: many protocols are line-based, including > QMP. Putting it in AsyncProtocol lets us keep the QMP class > implementation just a pinch more abstract. > > (And, if we decide to add a QTEST implementation later, it will need > this, too. (Yes, I have a QTEST implementation.)) > > Signed-off-by: John Snow > --- > python/qemu/aqmp/protocol.py | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org