From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
peterx@redhat.com,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH 2/4] qemu-config: Allow in-place sorting of QemuOptsList
Date: Wed, 18 Aug 2021 15:43:13 -0400 [thread overview]
Message-ID: <20210818194313.110892-1-peterx@redhat.com> (raw)
In-Reply-To: <20210818194217.110451-1-peterx@redhat.com>
Add the helper qemu_sort_opts() to allow in-place sorting of QemuOptsList. The
function can be specified in the form defined as qemu_opts_pri_fn(), where it
takes a QemuOpts pointer and generates a number showing the priority of this
QemuOpts entry.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
include/qemu/config-file.h | 4 ++++
util/qemu-config.c | 48 ++++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+)
diff --git a/include/qemu/config-file.h b/include/qemu/config-file.h
index f605423321..ce50a72985 100644
--- a/include/qemu/config-file.h
+++ b/include/qemu/config-file.h
@@ -3,8 +3,12 @@
typedef void QEMUConfigCB(const char *group, QDict *qdict, void *opaque, Error **errp);
+/* Returns the priority for a QemuOpts */
+typedef int (*qemu_opts_pri_fn)(QemuOpts *opt);
+
void qemu_load_module_for_opts(const char *group);
QemuOptsList *qemu_find_opts(const char *group);
+void qemu_sort_opts(const char *group, qemu_opts_pri_fn fn);
QemuOptsList *qemu_find_opts_err(const char *group, Error **errp);
QemuOpts *qemu_find_opts_singleton(const char *group);
diff --git a/util/qemu-config.c b/util/qemu-config.c
index 436ab63b16..e882dc948b 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -7,6 +7,7 @@
#include "qapi/qmp/qlist.h"
#include "qemu/error-report.h"
#include "qemu/option.h"
+#include "qemu/option_int.h"
#include "qemu/config-file.h"
static QemuOptsList *vm_config_groups[48];
@@ -41,6 +42,53 @@ QemuOptsList *qemu_find_opts(const char *group)
return ret;
}
+struct QemuOptsSortEntry {
+ QemuOpts *opts;
+ int priority;
+} __attribute__ ((__aligned__(sizeof(void *))));
+typedef struct QemuOptsSortEntry QemuOptsSortEntry;
+
+static int qemu_opts_cmp_fn(const void *opts_1, const void *opts_2)
+{
+ QemuOptsSortEntry *entry1, *entry2;
+
+ entry1 = (QemuOptsSortEntry *)opts_1;
+ entry2 = (QemuOptsSortEntry *)opts_2;
+
+ return entry1->priority - entry2->priority;
+}
+
+void qemu_sort_opts(const char *group, qemu_opts_pri_fn fn)
+{
+ QemuOptsSortEntry *entries, *entry;
+ QemuOpts *opts, *next_opts;
+ int i = 0, count = 0;
+ QemuOptsList *list;
+
+ list = find_list(vm_config_groups, group, &error_abort);
+
+ QTAILQ_FOREACH(opts, &list->head, next) {
+ count++;
+ }
+
+ entries = g_new0(QemuOptsSortEntry, count);
+ QTAILQ_FOREACH_SAFE(opts, &list->head, next, next_opts) {
+ entry = &entries[i++];
+ entry->opts = opts;
+ entry->priority = fn(opts);
+ /* Temporarily remove them; will add them back later */
+ QTAILQ_REMOVE(&list->head, opts, next);
+ }
+
+ qsort(entries, count, sizeof(QemuOptsSortEntry), qemu_opts_cmp_fn);
+
+ for (i = 0; i < count; i++) {
+ QTAILQ_INSERT_TAIL(&list->head, entries[i].opts, next);
+ }
+
+ g_free(entries);
+}
+
QemuOpts *qemu_find_opts_singleton(const char *group)
{
QemuOptsList *list;
--
2.31.1
next prev parent reply other threads:[~2021-08-18 19:53 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 19:42 [PATCH 0/4] vl: Prioritize device realizations Peter Xu
2021-08-18 19:42 ` [PATCH 1/4] qdev-monitor: Trace qdev creation Peter Xu
2021-08-18 19:43 ` Peter Xu [this message]
2021-08-18 19:43 ` [PATCH 3/4] qdev: Export qdev_get_device_class() Peter Xu
2021-08-18 19:43 ` [PATCH 4/4] vl: Prioritize realizations of devices Peter Xu
2021-08-23 18:49 ` Eduardo Habkost
2021-08-23 19:18 ` Peter Xu
2021-08-23 21:07 ` Eduardo Habkost
2021-08-23 21:31 ` Peter Xu
2021-08-23 21:54 ` Michael S. Tsirkin
2021-08-23 22:51 ` Peter Xu
2021-08-23 21:56 ` Eduardo Habkost
2021-08-23 23:05 ` Peter Xu
2021-08-25 9:39 ` Markus Armbruster
2021-08-25 12:28 ` Markus Armbruster
2021-08-25 21:50 ` Peter Xu
2021-08-26 3:50 ` Peter Xu
2021-08-26 8:01 ` Markus Armbruster
2021-08-26 11:36 ` Igor Mammedov
2021-08-26 13:43 ` Peter Xu
2021-08-30 19:02 ` Peter Xu
2021-08-31 11:35 ` Markus Armbruster
2021-09-02 8:26 ` Igor Mammedov
2021-09-02 13:45 ` Peter Xu
2021-09-02 13:53 ` Daniel P. Berrangé
2021-09-02 14:21 ` Peter Xu
2021-09-02 14:57 ` Markus Armbruster
2021-09-03 15:48 ` Peter Xu
2021-09-02 15:06 ` Daniel P. Berrangé
2021-09-02 15:26 ` Markus Armbruster
2021-09-03 13:00 ` Igor Mammedov
2021-09-03 16:03 ` Peter Xu
2021-09-06 8:49 ` Igor Mammedov
2021-09-02 7:46 ` Igor Mammedov
2021-08-26 4:57 ` Markus Armbruster
2021-08-23 22:05 ` Michael S. Tsirkin
2021-08-23 22:36 ` Peter Xu
2021-08-24 2:52 ` Jason Wang
2021-08-24 15:50 ` Peter Xu
2021-08-25 4:23 ` Jason Wang
2021-09-06 9:22 ` Eric Auger
2021-08-24 16:24 ` David Hildenbrand
2021-08-24 19:52 ` Peter Xu
2021-08-25 8:08 ` David Hildenbrand
2021-08-24 2:51 ` Jason Wang
2021-10-20 13:44 ` [PATCH 0/4] vl: Prioritize device realizations David Hildenbrand
2021-10-20 13:48 ` Daniel P. Berrangé
2021-10-20 13:58 ` David Hildenbrand
2021-10-21 4:20 ` Peter Xu
2021-10-21 7:17 ` David Hildenbrand
2021-10-21 8:00 ` Peter Xu
2021-10-21 16:54 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818194313.110892-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).