From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 575ECC4338F for ; Thu, 19 Aug 2021 14:52:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC09B610A1 for ; Thu, 19 Aug 2021 14:52:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC09B610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:40838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGjOr-0003NE-3j for qemu-devel@archiver.kernel.org; Thu, 19 Aug 2021 10:52:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGjNN-0001xr-VP for qemu-devel@nongnu.org; Thu, 19 Aug 2021 10:50:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGjNK-00070Q-6w for qemu-devel@nongnu.org; Thu, 19 Aug 2021 10:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629384630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/jV5AOhehcXnsiVYnpwKAp9ndGWrR0UP11wArpKGrDM=; b=b3EeRp2kBiPWk2DYk6n2WsaXaf3swVmIhv85FdlBxXCIuaHxb7K/QAdOJrnGQPsoLEelQD eoH9X7T6r+iJ4I1NZgPNDzjhxXvpzTnBmDPe6WQbcn6D7fgLMfZWelwXX5jwWN64huchyZ XUJVXO5MbtDgtXxGNNJEP6fBfJ2gCXc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421--LHDH04UNJeVKaI57N2vRg-1; Thu, 19 Aug 2021 10:50:26 -0400 X-MC-Unique: -LHDH04UNJeVKaI57N2vRg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B519DC73BA; Thu, 19 Aug 2021 14:50:25 +0000 (UTC) Received: from redhat.com (ovpn-114-146.phx2.redhat.com [10.3.114.146]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD37717567; Thu, 19 Aug 2021 14:50:10 +0000 (UTC) Date: Thu, 19 Aug 2021 09:50:09 -0500 From: Eric Blake To: John Snow Subject: Re: [PATCH v3 09/25] python/aqmp: add AsyncProtocol.accept() method Message-ID: <20210819145009.4feupwleh4iyltkw@redhat.com> References: <20210803182941.504537-1-jsnow@redhat.com> <20210803182941.504537-10-jsnow@redhat.com> <20210817192949.cglc7ah2ohlmtf43@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20210205-732-28786f X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Willian Rampazzo , Markus Armbruster , Wainer dos Santos Moschetta , qemu-devel , "Niteesh G . S ." , Stefan Hajnoczi , Cleber Rosa , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Aug 18, 2021 at 10:24:52AM -0400, John Snow wrote: > > > > > > + @upper_half > > > + @require(Runstate.IDLE) > > > + async def accept(self, address: Union[str, Tuple[str, int]], > > > + ssl: Optional[SSLContext] = None) -> None: > > > + """ > > > + Accept a connection and begin processing message queues. > > > + > > > + If this call fails, `runstate` is guaranteed to be set back to > > `IDLE`. > > > + > > > + :param address: > > > + Address to listen to; UNIX socket path or TCP address/port. > > > > Can't TCP use a well-known port name instead of an int? But limiting > > clients to just int port for now isn't fatal to the patch. > > > > > The old QMP library didn't support this, and I used the old library as my > template here. I'm willing to change the address format and types to be > more comprehensive, but I was thinking that it should probably try to match > or adhere to some standard; de-facto or otherwise. I wasn't sure which to > pick, and we use a few different ones in QEMU itself. Any recommendations > for me? I asked because I know QAPI specifies TCP as string/string (the hostname as a string makes absolute sense, but the port number as a string is because of the less-used feature of a well-known port name). I'm fine if the initial patch uses an int for the port number here; we can always add support for more formats down the road when someone actually has a use for them. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org