From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Sergio Lopez" <slp@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v2 2/3] hw/usb/hcd-xhci-pci: Abort if setting link property failed
Date: Thu, 19 Aug 2021 19:15:46 +0200 [thread overview]
Message-ID: <20210819171547.2879725-3-philmd@redhat.com> (raw)
In-Reply-To: <20210819171547.2879725-1-philmd@redhat.com>
Do not ignore eventual error if we failed at setting the 'host'
property of the TYPE_XHCI model.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/usb/hcd-xhci-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci-pci.c b/hw/usb/hcd-xhci-pci.c
index e934b1a5b1f..71f6629ccde 100644
--- a/hw/usb/hcd-xhci-pci.c
+++ b/hw/usb/hcd-xhci-pci.c
@@ -115,7 +115,7 @@ static void usb_xhci_pci_realize(struct PCIDevice *dev, Error **errp)
dev->config[PCI_CACHE_LINE_SIZE] = 0x10;
dev->config[0x60] = 0x30; /* release number */
- object_property_set_link(OBJECT(&s->xhci), "host", OBJECT(s), NULL);
+ object_property_set_link(OBJECT(&s->xhci), "host", OBJECT(s), &error_fatal);
s->xhci.intr_update = xhci_pci_intr_update;
s->xhci.intr_raise = xhci_pci_intr_raise;
if (!qdev_realize(DEVICE(&s->xhci), NULL, errp)) {
--
2.31.1
next prev parent reply other threads:[~2021-08-19 17:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 17:15 [PATCH v2 0/3] hw/usb: Always expect 'dma' link property to be set to simplify Philippe Mathieu-Daudé
2021-08-19 17:15 ` [PATCH v2 1/3] hw/pci: Introduce pci_dma_memory_region() helper Philippe Mathieu-Daudé
2021-08-19 17:15 ` Philippe Mathieu-Daudé [this message]
2021-08-23 18:34 ` [PATCH v2 2/3] hw/usb/hcd-xhci-pci: Abort if setting link property failed Eduardo Habkost
2021-08-24 8:13 ` Markus Armbruster
2021-08-24 8:35 ` Philippe Mathieu-Daudé
2021-08-24 8:46 ` Philippe Mathieu-Daudé
2021-08-24 9:19 ` Peter Maydell
2021-08-24 12:05 ` Markus Armbruster
2021-08-24 12:16 ` Peter Maydell
2021-08-24 13:57 ` Eduardo Habkost
2021-08-24 14:24 ` Peter Maydell
2021-08-24 14:29 ` Markus Armbruster
2021-08-24 14:27 ` Markus Armbruster
2021-08-24 14:30 ` Peter Maydell
2021-08-24 15:15 ` Markus Armbruster
2021-08-24 15:19 ` Peter Maydell
2021-08-25 7:48 ` Markus Armbruster
2021-08-19 17:15 ` [PATCH v2 3/3] hw/usb/xhci: Always expect 'dma' link property to be set Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819171547.2879725-3-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).