From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19BCC4320A for ; Fri, 20 Aug 2021 12:14:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F4306108F for ; Fri, 20 Aug 2021 12:14:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9F4306108F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:56492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mH3Pp-0003mh-EC for qemu-devel@archiver.kernel.org; Fri, 20 Aug 2021 08:14:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH3Oq-0001mA-7E; Fri, 20 Aug 2021 08:13:28 -0400 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:41833) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mH3Oo-0003ww-Iu; Fri, 20 Aug 2021 08:13:28 -0400 Received: by mail-lj1-x22a.google.com with SMTP id h9so16954891ljq.8; Fri, 20 Aug 2021 05:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eyZN5CWzhpm/Wk3iDTB+oL/QYFODksW881M4ZWKhYwA=; b=vHR8YGvidGR0qOMxqhcsFVwJ8LXOpy49H3BcFr/JrPfabGSloGWSG9RKp+ZYoyfgYb KdCHQiLdPVozD4fTapz7oQtMx4hTZ16zofUvHA1ByZV9/8XkEuG22Ma3g3TBLRA/+zCW apblvDcrV+5dgnQIUOqjmXVWGQ5hNpk+hk80UFnSC57m52KU8rZwztFl/F6GHYUKrKBX LYkhCMw3a7KwXiVIifgMHcJSAKbYZ+T4GOMPA4/dMOjkTRopWqSYKAJmFIboNNw/PtNu 2nH6/fyI4Wr5BXwtd/QhiCRSVtw2N2yAtqf4OpfnGE+11bR370dy0WvLUTIzIJBCYxzR SD7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eyZN5CWzhpm/Wk3iDTB+oL/QYFODksW881M4ZWKhYwA=; b=O5Nfm+/04Yi26k4uG4SEXqrjn/ddL/PULCkR2ZrEEZPTSYKXU4bwsX2KXnfHLxP8gH 7y9jSCNLSAgvn4oj3pfxAaI9QexD5u7dvDjWtRivJq839+PfDMDPhO5/0NuhRV0l2KCG WLR45oGMOSLQO694Gqdi9nU3apzcBoWLa6N56F7K74nAPFldf2/xf6WTyGjt3ZtbrnsG 30/1IpXeWiTXPJ0EBWI10AHP0wDf84iFKURQ/kT29+ql5u2TsM+YV2rRInvRI9YeBe7r 6/oZH6ESL0fszM/2AzE5HTkUQR+1nFQzfEYLHPDOuIG17Q6xQtCNneibD+nUdtZ9XiyX sK5A== X-Gm-Message-State: AOAM5305aIg75fvG/9y1El6J0Ohtt3mRhKIEwJpQry1SKD116cqZTRT2 bIyxoDBw56Npt2+sPfUPqtE= X-Google-Smtp-Source: ABdhPJwveTig1J1YczVEsyfcJ1LIMesiqvHNnaJifftdANTnL40ESU7HBcGjGr5f971Liu40kdQSOA== X-Received: by 2002:a2e:6c09:: with SMTP id h9mr2547521ljc.30.1629461603710; Fri, 20 Aug 2021 05:13:23 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id k22sm615427lfm.263.2021.08.20.05.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Aug 2021 05:13:23 -0700 (PDT) Date: Fri, 20 Aug 2021 14:13:22 +0200 From: "Edgar E. Iglesias" To: Tong Ho Subject: Re: [Patch 1/2] hw/arm/xlnx-versal: Add unimplemented APU mmio Message-ID: <20210820121322.GH3586016@toto> References: <20210819031525.653995-1-tong.ho@xilinx.com> <20210819031525.653995-2-tong.ho@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210819031525.653995-2-tong.ho@xilinx.com> Received-SPF: pass client-ip=2a00:1450:4864:20::22a; envelope-from=edgar.iglesias@gmail.com; helo=mail-lj1-x22a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, alistair@alistair23.me Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Aug 18, 2021 at 08:15:24PM -0700, Tong Ho wrote: > Add unimplemented APU mmio region to xlnx-versal for booting > bare-metal guests built with standalone bsp published at: > https://github.com/Xilinx/embeddedsw/tree/master/lib/bsp/standalone/src/arm/ARMv8/64bit Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Tong Ho > --- > hw/arm/xlnx-versal.c | 2 ++ > include/hw/arm/xlnx-versal.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c > index fb776834f7..cb6ec0a4a0 100644 > --- a/hw/arm/xlnx-versal.c > +++ b/hw/arm/xlnx-versal.c > @@ -376,6 +376,8 @@ static void versal_unimp(Versal *s) > MM_CRL, MM_CRL_SIZE); > versal_unimp_area(s, "crf", &s->mr_ps, > MM_FPD_CRF, MM_FPD_CRF_SIZE); > + versal_unimp_area(s, "apu", &s->mr_ps, > + MM_FPD_FPD_APU, MM_FPD_FPD_APU_SIZE); > versal_unimp_area(s, "crp", &s->mr_ps, > MM_PMC_CRP, MM_PMC_CRP_SIZE); > versal_unimp_area(s, "iou-scntr", &s->mr_ps, > diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h > index 22a8fa5d11..9b79051747 100644 > --- a/include/hw/arm/xlnx-versal.h > +++ b/include/hw/arm/xlnx-versal.h > @@ -167,6 +167,8 @@ struct Versal { > #define MM_IOU_SCNTRS_SIZE 0x10000 > #define MM_FPD_CRF 0xfd1a0000U > #define MM_FPD_CRF_SIZE 0x140000 > +#define MM_FPD_FPD_APU 0xfd5c0000 > +#define MM_FPD_FPD_APU_SIZE 0x100 > > #define MM_PMC_SD0 0xf1040000U > #define MM_PMC_SD0_SIZE 0x10000 > -- > 2.25.1 >