From: Andrew Jones <drjones@redhat.com>
To: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, richard.henderson@linaro.org,
ishii.shuuichir@fujitsu.com, philmd@redhat.com
Subject: [PATCH v2 2/4] target/arm/kvm64: Ensure sve vls map is completely clear
Date: Mon, 23 Aug 2021 18:06:45 +0200 [thread overview]
Message-ID: <20210823160647.34028-3-drjones@redhat.com> (raw)
In-Reply-To: <20210823160647.34028-1-drjones@redhat.com>
bitmap_clear() only clears the given range. While the given
range should be sufficient in this case we might as well be
100% sure all bits are zeroed by using bitmap_zero().
Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
target/arm/kvm64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c
index 59982d470d37..e790d6c9a573 100644
--- a/target/arm/kvm64.c
+++ b/target/arm/kvm64.c
@@ -740,7 +740,7 @@ void kvm_arm_sve_get_vls(CPUState *cs, unsigned long *map)
uint32_t vq = 0;
int i, j;
- bitmap_clear(map, 0, ARM_MAX_VQ);
+ bitmap_zero(map, ARM_MAX_VQ);
/*
* KVM ensures all host CPUs support the same set of vector lengths.
--
2.31.1
next prev parent reply other threads:[~2021-08-23 16:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 16:06 [PATCH v2 0/4] target/arm/cpu: Introduce sve_vq_supported bitmap Andrew Jones
2021-08-23 16:06 ` [PATCH v2 1/4] " Andrew Jones
2021-08-23 17:43 ` Richard Henderson
2021-08-23 16:06 ` Andrew Jones [this message]
2021-08-23 17:45 ` [PATCH v2 2/4] target/arm/kvm64: Ensure sve vls map is completely clear Richard Henderson
2021-08-23 16:06 ` [PATCH v2 3/4] target/arm/cpu64: Replace kvm_supported with sve_vq_supported Andrew Jones
2021-08-23 17:53 ` Richard Henderson
2021-08-24 6:28 ` Andrew Jones
2021-08-24 6:47 ` Andrew Jones
2021-08-23 16:06 ` [PATCH v2 4/4] target/arm/cpu64: Validate sve vector lengths are supported Andrew Jones
2021-08-23 18:04 ` Richard Henderson
2021-08-24 6:28 ` Andrew Jones
2021-08-26 13:22 ` [PATCH v2 0/4] target/arm/cpu: Introduce sve_vq_supported bitmap Peter Maydell
2021-08-27 8:30 ` ishii.shuuichir
2021-08-27 8:57 ` Peter Maydell
2021-08-30 0:02 ` ishii.shuuichir
2021-08-27 10:03 ` Andrew Jones
2021-08-30 4:49 ` ishii.shuuichir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823160647.34028-3-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=ishii.shuuichir@fujitsu.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).