From: Keith Busch <kbusch@kernel.org>
To: Klaus Jensen <its@irrelevant.dk>
Cc: Klaus Jensen <k.jensen@samsung.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] hw/nvme: fix validation of ASQ and ACQ
Date: Mon, 23 Aug 2021 19:47:48 -0600 [thread overview]
Message-ID: <20210824014748.GA64408@C02WT3WMHTD6> (raw)
In-Reply-To: <20210823122018.401370-1-its@irrelevant.dk>
On Mon, Aug 23, 2021 at 02:20:18PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Address 0x0 is a valid address. Fix the admin submission and completion
> queue address validation to not error out on this.
Indeed, there are environments that can use that address. It's a host error if
the controller was enabled with invalid queue addresses anyway. The controller
only needs to verify the lower bits are clear, which we do later.
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2021-08-24 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 12:20 [PATCH] hw/nvme: fix validation of ASQ and ACQ Klaus Jensen
2021-08-24 1:47 ` Keith Busch [this message]
2021-08-24 5:26 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824014748.GA64408@C02WT3WMHTD6 \
--to=kbusch@kernel.org \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).