qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: matheus.ferst@eldorado.org.br
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: peter.maydell@linaro.org,
	Matheus Ferst <matheus.ferst@eldorado.org.br>,
	groug@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH 0/2] target/ppc: Fix vextu[bhw][lr]x on big endian hosts
Date: Tue, 24 Aug 2021 17:11:03 -0300	[thread overview]
Message-ID: <20210824201105.2303789-1-matheus.ferst@eldorado.org.br> (raw)

From: Matheus Ferst <matheus.ferst@eldorado.org.br>

The definition of struct Int128 is currently independent of the host
endianness, causing different results when using the member s128 of
union ppc_vsr_t in big-endian builds with CONFIG_INT128 or
!CONFIG_INT128.

The only PPC instructions that seem to be affected by this issue are the
"Vector Extract Unsigned Byte/Halfword/Word to GPR using GPR-specified
Left/Right-Index." Even on builds with Int128 support, however, their
helpers give the wrong result on big-endian hosts.

The first patch in this series changes the definition of struct Int128
to allow its use in the ppc_vsr_t union. The second patch fixes the
helper definition.

Matheus Ferst (2):
  include/qemu/int128.h: define struct Int128 according to the host
    endianness
  target/ppc: fix vextu[bhw][lr]x helpers

 include/qemu/int128.h   | 19 ++++++++++++-------
 target/ppc/int_helper.c | 38 ++++++++++----------------------------
 2 files changed, 22 insertions(+), 35 deletions(-)

-- 
2.25.1



             reply	other threads:[~2021-08-24 20:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 20:11 matheus.ferst [this message]
2021-08-24 20:11 ` [PATCH 1/2] include/qemu/int128.h: define struct Int128 according to the host endianness matheus.ferst
2021-08-26 13:11   ` Peter Maydell
2021-08-26 13:14     ` Peter Maydell
2021-08-24 20:11 ` [PATCH 2/2] target/ppc: fix vextu[bhw][lr]x helpers matheus.ferst
2021-08-25  3:02   ` David Gibson
2021-08-25  3:02 ` [PATCH 0/2] target/ppc: Fix vextu[bhw][lr]x on big endian hosts David Gibson
2021-08-25  5:32 ` Philippe Mathieu-Daudé
2021-08-25 12:55 ` Mark Cave-Ayland
2021-08-26  1:28   ` Matheus K. Ferst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210824201105.2303789-1-matheus.ferst@eldorado.org.br \
    --to=matheus.ferst@eldorado.org.br \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).