From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com,
Daniel Henrique Barboza <danielhb413@gmail.com>,
qemu-ppc@nongnu.org, groug@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH v7 1/7] memory_hotplug.c: handle dev->id = NULL in acpi_memory_hotplug_write()
Date: Tue, 24 Aug 2021 21:48:29 -0300 [thread overview]
Message-ID: <20210825004835.472919-2-danielhb413@gmail.com> (raw)
In-Reply-To: <20210825004835.472919-1-danielhb413@gmail.com>
qapi_event_send_mem_unplug_error() deals with @device being NULL by
replacing it with an empty string ("") when emitting the event. Aside
from the fact that this behavior (qapi visitor mapping NULL pointer to
"") can be patched/changed someday, there's also the lack of utility
that the event brings to listeners, e.g. "a memory unplug error happened
somewhere".
In theory we should just avoit emitting this event at all if dev->id is
NULL, but this would be an incompatible change to existing guests.
Instead, let's make the forementioned behavior explicit: if dev->id is
NULL, pass an empty string to qapi_event_send_mem_unplug_error().
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
hw/acpi/memory_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
index af37889423..6a71de408b 100644
--- a/hw/acpi/memory_hotplug.c
+++ b/hw/acpi/memory_hotplug.c
@@ -178,7 +178,7 @@ static void acpi_memory_hotplug_write(void *opaque, hwaddr addr, uint64_t data,
hotplug_handler_unplug(hotplug_ctrl, dev, &local_err);
if (local_err) {
trace_mhp_acpi_pc_dimm_delete_failed(mem_st->selector);
- qapi_event_send_mem_unplug_error(dev->id,
+ qapi_event_send_mem_unplug_error(dev->id ? : "",
error_get_pretty(local_err));
error_free(local_err);
break;
--
2.31.1
next prev parent reply other threads:[~2021-08-25 0:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 0:48 [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event Daniel Henrique Barboza
2021-08-25 0:48 ` Daniel Henrique Barboza [this message]
2021-08-25 3:49 ` [PATCH v7 1/7] memory_hotplug.c: handle dev->id = NULL in acpi_memory_hotplug_write() David Gibson
2021-08-25 12:12 ` Igor Mammedov
2021-08-25 13:47 ` Greg Kurz
2021-08-25 0:48 ` [PATCH v7 2/7] spapr.c: handle dev->id in spapr_memory_unplug_rollback() Daniel Henrique Barboza
2021-08-25 3:49 ` David Gibson
2021-08-25 13:51 ` Greg Kurz
2021-08-25 0:48 ` [PATCH v7 3/7] spapr_drc.c: do not error_report() when drc->dev->id == NULL Daniel Henrique Barboza
2021-08-25 3:50 ` David Gibson
2021-08-25 0:48 ` [PATCH v7 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc Daniel Henrique Barboza
2021-08-25 3:50 ` David Gibson
2021-08-25 0:48 ` [PATCH v7 5/7] qapi/qdev.json: add DEVICE_UNPLUG_GUEST_ERROR QAPI event Daniel Henrique Barboza
2021-08-25 3:53 ` David Gibson
2021-08-25 13:53 ` Greg Kurz
2021-09-01 13:19 ` Markus Armbruster
2021-09-04 3:53 ` David Gibson
2021-09-04 11:49 ` Markus Armbruster
2021-09-06 12:40 ` Daniel Henrique Barboza
2021-09-06 23:24 ` David Gibson
2021-08-25 0:48 ` [PATCH v7 6/7] spapr: use DEVICE_UNPLUG_GUEST_ERROR to report unplug errors Daniel Henrique Barboza
2021-08-25 3:54 ` David Gibson
2021-08-25 0:48 ` [PATCH v7 7/7] memory_hotplug.c: send DEVICE_UNPLUG_GUEST_ERROR in acpi_memory_hotplug_write() Daniel Henrique Barboza
2021-08-25 3:55 ` David Gibson
2021-08-25 12:14 ` Igor Mammedov
2021-08-30 22:21 ` Michael S. Tsirkin
2021-09-01 13:20 ` [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event Markus Armbruster
2021-09-22 11:56 ` Markus Armbruster
2021-09-22 12:03 ` Markus Armbruster
2021-09-24 2:15 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825004835.472919-2-danielhb413@gmail.com \
--to=danielhb413@gmail.com \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).