qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com,
	Daniel Henrique Barboza <danielhb413@gmail.com>,
	qemu-ppc@nongnu.org, groug@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH v7 2/7] spapr.c: handle dev->id in spapr_memory_unplug_rollback()
Date: Tue, 24 Aug 2021 21:48:30 -0300	[thread overview]
Message-ID: <20210825004835.472919-3-danielhb413@gmail.com> (raw)
In-Reply-To: <20210825004835.472919-1-danielhb413@gmail.com>

As done in hw/acpi/memory_hotplug.c, pass an empty string if dev->id
is NULL to qapi_event_send_mem_unplug_error() to avoid relying on
a behavior that can be changed in the future.

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 hw/ppc/spapr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 81699d4f8b..4f1ee90e9e 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3690,7 +3690,7 @@ void spapr_memory_unplug_rollback(SpaprMachineState *spapr, DeviceState *dev)
      */
     qapi_error = g_strdup_printf("Memory hotunplug rejected by the guest "
                                  "for device %s", dev->id);
-    qapi_event_send_mem_unplug_error(dev->id, qapi_error);
+    qapi_event_send_mem_unplug_error(dev->id ? : "", qapi_error);
 }
 
 /* Callback to be called during DRC release. */
-- 
2.31.1



  parent reply	other threads:[~2021-08-25  0:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  0:48 [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event Daniel Henrique Barboza
2021-08-25  0:48 ` [PATCH v7 1/7] memory_hotplug.c: handle dev->id = NULL in acpi_memory_hotplug_write() Daniel Henrique Barboza
2021-08-25  3:49   ` David Gibson
2021-08-25 12:12   ` Igor Mammedov
2021-08-25 13:47   ` Greg Kurz
2021-08-25  0:48 ` Daniel Henrique Barboza [this message]
2021-08-25  3:49   ` [PATCH v7 2/7] spapr.c: handle dev->id in spapr_memory_unplug_rollback() David Gibson
2021-08-25 13:51   ` Greg Kurz
2021-08-25  0:48 ` [PATCH v7 3/7] spapr_drc.c: do not error_report() when drc->dev->id == NULL Daniel Henrique Barboza
2021-08-25  3:50   ` David Gibson
2021-08-25  0:48 ` [PATCH v7 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc Daniel Henrique Barboza
2021-08-25  3:50   ` David Gibson
2021-08-25  0:48 ` [PATCH v7 5/7] qapi/qdev.json: add DEVICE_UNPLUG_GUEST_ERROR QAPI event Daniel Henrique Barboza
2021-08-25  3:53   ` David Gibson
2021-08-25 13:53   ` Greg Kurz
2021-09-01 13:19   ` Markus Armbruster
2021-09-04  3:53     ` David Gibson
2021-09-04 11:49       ` Markus Armbruster
2021-09-06 12:40         ` Daniel Henrique Barboza
2021-09-06 23:24           ` David Gibson
2021-08-25  0:48 ` [PATCH v7 6/7] spapr: use DEVICE_UNPLUG_GUEST_ERROR to report unplug errors Daniel Henrique Barboza
2021-08-25  3:54   ` David Gibson
2021-08-25  0:48 ` [PATCH v7 7/7] memory_hotplug.c: send DEVICE_UNPLUG_GUEST_ERROR in acpi_memory_hotplug_write() Daniel Henrique Barboza
2021-08-25  3:55   ` David Gibson
2021-08-25 12:14   ` Igor Mammedov
2021-08-30 22:21   ` Michael S. Tsirkin
2021-09-01 13:20 ` [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event Markus Armbruster
2021-09-22 11:56 ` Markus Armbruster
2021-09-22 12:03   ` Markus Armbruster
2021-09-24  2:15     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210825004835.472919-3-danielhb413@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=armbru@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).