From: Stefan Reiter <s.reiter@proxmox.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: qemu-devel@nongnu.org
Subject: [PATCH 0/2] VNC-related HMP/QMP fixes
Date: Wed, 25 Aug 2021 11:36:59 +0200 [thread overview]
Message-ID: <20210825093701.668122-1-s.reiter@proxmox.com> (raw)
Since the removal of the generic 'qmp_change' command, one can no longer replace
the 'default' VNC display listen address at runtime (AFAIK). For our users who
need to set up a secondary VNC access port, this means configuring a second VNC
display (in addition to our standard one for web-access), but it turns out one
cannot set a password on this second display at the moment, as the
'set_password' call only operates on the 'default' display.
Additionally, using secret objects, the password is only read once at startup.
This could be considered a bug too, but is not touched in this series and left
for a later date.
Stefan Reiter (2):
monitor/hmp: correctly invert password argument detection again
monitor: allow VNC related QMP and HMP commands to take a display ID
hmp-commands.hx | 28 +++++++++++++++-------------
monitor/hmp-cmds.c | 22 +++++++++++++++++++---
monitor/qmp-cmds.c | 9 +++++----
qapi/ui.json | 12 ++++++++++--
4 files changed, 49 insertions(+), 22 deletions(-)
--
2.30.2
next reply other threads:[~2021-08-25 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 9:36 Stefan Reiter [this message]
2021-08-25 9:37 ` [PATCH 1/2] monitor/hmp: correctly invert password argument detection again Stefan Reiter
2021-08-25 10:42 ` Marc-André Lureau
2021-08-25 9:37 ` [PATCH 2/2] monitor: allow VNC related QMP and HMP commands to take a display ID Stefan Reiter
2021-08-25 10:59 ` Marc-André Lureau
2021-08-25 11:26 ` Stefan Reiter
2021-08-25 19:20 ` Eric Blake
2021-08-25 19:16 ` Eric Blake
2021-08-31 12:20 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825093701.668122-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).