From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD481C4338F for ; Wed, 25 Aug 2021 13:52:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72EF560E93 for ; Wed, 25 Aug 2021 13:52:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 72EF560E93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:55948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mItKE-0005JA-N2 for qemu-devel@archiver.kernel.org; Wed, 25 Aug 2021 09:52:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mItJF-0003cc-CO for qemu-devel@nongnu.org; Wed, 25 Aug 2021 09:51:17 -0400 Received: from us-smtp-delivery-44.mimecast.com ([207.211.30.44]:42513) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mItJE-0003fb-1L for qemu-devel@nongnu.org; Wed, 25 Aug 2021 09:51:17 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379--VQZVp4HP6uhSbphaaTP6g-1; Wed, 25 Aug 2021 09:51:12 -0400 X-MC-Unique: -VQZVp4HP6uhSbphaaTP6g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0317185302B; Wed, 25 Aug 2021 13:51:10 +0000 (UTC) Received: from bahia.lan (unknown [10.39.194.209]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7312160657; Wed, 25 Aug 2021 13:51:09 +0000 (UTC) Date: Wed, 25 Aug 2021 15:51:08 +0200 From: Greg Kurz To: Daniel Henrique Barboza Subject: Re: [PATCH v7 2/7] spapr.c: handle dev->id in spapr_memory_unplug_rollback() Message-ID: <20210825155108.71391e72@bahia.lan> In-Reply-To: <20210825004835.472919-3-danielhb413@gmail.com> References: <20210825004835.472919-1-danielhb413@gmail.com> <20210825004835.472919-3-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=207.211.30.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 24 Aug 2021 21:48:30 -0300 Daniel Henrique Barboza wrote: > As done in hw/acpi/memory_hotplug.c, pass an empty string if dev->id > is NULL to qapi_event_send_mem_unplug_error() to avoid relying on > a behavior that can be changed in the future. >=20 > Suggested-by: Markus Armbruster > Signed-off-by: Daniel Henrique Barboza > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 81699d4f8b..4f1ee90e9e 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -3690,7 +3690,7 @@ void spapr_memory_unplug_rollback(SpaprMachineState= *spapr, DeviceState *dev) > */ > qapi_error =3D g_strdup_printf("Memory hotunplug rejected by the gue= st " > "for device %s", dev->id); > - qapi_event_send_mem_unplug_error(dev->id, qapi_error); > + qapi_event_send_mem_unplug_error(dev->id ? : "", qapi_error); > } > =20 > /* Callback to be called during DRC release. */