* [PATCH] Add qemu_vga.ndrv to build/pc-bios folder
@ 2021-08-31 16:50 John Arbuckle
2021-08-31 20:33 ` Mark Cave-Ayland
0 siblings, 1 reply; 6+ messages in thread
From: John Arbuckle @ 2021-08-31 16:50 UTC (permalink / raw)
To: peter.maydell, groug, david, qemu-ppc, qemu-devel, hsp.cat7,
balaton, mark.cave-ayland
Cc: John Arbuckle
Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices.
Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 9a79a004d7..281577e46f 100755
--- a/configure
+++ b/configure
@@ -5056,7 +5056,9 @@ for bios_file in \
$source_path/pc-bios/openbios-* \
$source_path/pc-bios/u-boot.* \
$source_path/pc-bios/edk2-*.fd.bz2 \
- $source_path/pc-bios/palcode-*
+ $source_path/pc-bios/palcode-* \
+ $source_path/pc-bios/qemu_vga.ndrv
+
do
LINKS="$LINKS pc-bios/$(basename $bios_file)"
done
--
2.24.3 (Apple Git-128)
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Add qemu_vga.ndrv to build/pc-bios folder
2021-08-31 16:50 [PATCH] Add qemu_vga.ndrv to build/pc-bios folder John Arbuckle
@ 2021-08-31 20:33 ` Mark Cave-Ayland
2021-08-31 20:52 ` Programmingkid
0 siblings, 1 reply; 6+ messages in thread
From: Mark Cave-Ayland @ 2021-08-31 20:33 UTC (permalink / raw)
To: John Arbuckle, peter.maydell, groug, david, qemu-ppc, qemu-devel,
hsp.cat7, balaton
On 31/08/2021 17:50, John Arbuckle wrote:
> Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices.
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
> ---
> configure | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 9a79a004d7..281577e46f 100755
> --- a/configure
> +++ b/configure
> @@ -5056,7 +5056,9 @@ for bios_file in \
> $source_path/pc-bios/openbios-* \
> $source_path/pc-bios/u-boot.* \
> $source_path/pc-bios/edk2-*.fd.bz2 \
> - $source_path/pc-bios/palcode-*
> + $source_path/pc-bios/palcode-* \
> + $source_path/pc-bios/qemu_vga.ndrv
> +
> do
> LINKS="$LINKS pc-bios/$(basename $bios_file)"
> done
I think the patch looks correct, however the commit message and subject aren't quite
right. How about something like:
[PATCH] configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree
Ensure that a link to pc-bios/qemu_vga.ndrv is added to the build tree, otherwise the
optional MacOS client driver will not be loaded by OpenBIOS when launching QEMU
directly from the build directory.
ATB,
Mark.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add qemu_vga.ndrv to build/pc-bios folder
2021-08-31 20:33 ` Mark Cave-Ayland
@ 2021-08-31 20:52 ` Programmingkid
2021-09-15 14:02 ` Laurent Vivier
0 siblings, 1 reply; 6+ messages in thread
From: Programmingkid @ 2021-08-31 20:52 UTC (permalink / raw)
To: Mark Cave-Ayland
Cc: Peter Maydell, qemu-devel, groug, qemu-ppc, hsp.cat7, david
> On Aug 31, 2021, at 4:33 PM, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote:
>
> On 31/08/2021 17:50, John Arbuckle wrote:
>
>> Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices.
>> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>> ---
>> configure | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> diff --git a/configure b/configure
>> index 9a79a004d7..281577e46f 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5056,7 +5056,9 @@ for bios_file in \
>> $source_path/pc-bios/openbios-* \
>> $source_path/pc-bios/u-boot.* \
>> $source_path/pc-bios/edk2-*.fd.bz2 \
>> - $source_path/pc-bios/palcode-*
>> + $source_path/pc-bios/palcode-* \
>> + $source_path/pc-bios/qemu_vga.ndrv
>> +
>> do
>> LINKS="$LINKS pc-bios/$(basename $bios_file)"
>> done
>
> I think the patch looks correct, however the commit message and subject aren't quite right. How about something like:
>
> [PATCH] configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree
>
> Ensure that a link to pc-bios/qemu_vga.ndrv is added to the build tree, otherwise the optional MacOS client driver will not be loaded by OpenBIOS when launching QEMU directly from the build directory.
>
>
> ATB,
>
> Mark.
Ok. I will create a new patch with these changes.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add qemu_vga.ndrv to build/pc-bios folder
2021-08-31 20:52 ` Programmingkid
@ 2021-09-15 14:02 ` Laurent Vivier
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2021-09-15 14:02 UTC (permalink / raw)
To: Programmingkid, Mark Cave-Ayland
Cc: Peter Maydell, QEMU Developers, groug, qemu-ppc, hsp.cat7, david
Le 31/08/2021 à 22:52, Programmingkid a écrit :
>
>
>> On Aug 31, 2021, at 4:33 PM, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote:
>>
>> On 31/08/2021 17:50, John Arbuckle wrote:
>>
>>> Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices.
>>> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>>> ---
>>> configure | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>> diff --git a/configure b/configure
>>> index 9a79a004d7..281577e46f 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -5056,7 +5056,9 @@ for bios_file in \
>>> $source_path/pc-bios/openbios-* \
>>> $source_path/pc-bios/u-boot.* \
>>> $source_path/pc-bios/edk2-*.fd.bz2 \
>>> - $source_path/pc-bios/palcode-*
>>> + $source_path/pc-bios/palcode-* \
>>> + $source_path/pc-bios/qemu_vga.ndrv
>>> +
>>> do
>>> LINKS="$LINKS pc-bios/$(basename $bios_file)"
>>> done
>>
>> I think the patch looks correct, however the commit message and subject aren't quite right. How about something like:
>>
>> [PATCH] configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree
>>
>> Ensure that a link to pc-bios/qemu_vga.ndrv is added to the build tree, otherwise the optional MacOS client driver will not be loaded by OpenBIOS when launching QEMU directly from the build directory.
>>
>>
>> ATB,
>>
>> Mark.
>
> Ok. I will create a new patch with these changes.
>
Applied to my trivial-patches branch with Mark's commit message rewording and Peter's R-b.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20210901121620.1320-1-programmingkidx@gmail.com>]
* Re: [PATCH] Add qemu_vga.ndrv to build/pc-bios folder
[not found] <20210901121620.1320-1-programmingkidx@gmail.com>
@ 2021-09-15 13:27 ` Laurent Vivier
2021-09-15 13:48 ` Peter Maydell
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Vivier @ 2021-09-15 13:27 UTC (permalink / raw)
To: John Arbuckle; +Cc: qemu-trivial, Mark Cave-Ayland, mjt, QEMU Developers
CC Mark
CC qemu-devel
Le 01/09/2021 à 14:16, John Arbuckle a écrit :
> Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices.
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
> ---
> configure | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 9a79a004d7..281577e46f 100755
> --- a/configure
> +++ b/configure
> @@ -5056,7 +5056,9 @@ for bios_file in \
> $source_path/pc-bios/openbios-* \
> $source_path/pc-bios/u-boot.* \
> $source_path/pc-bios/edk2-*.fd.bz2 \
> - $source_path/pc-bios/palcode-*
> + $source_path/pc-bios/palcode-* \
> + $source_path/pc-bios/qemu_vga.ndrv
> +
> do
> LINKS="$LINKS pc-bios/$(basename $bios_file)"
> done
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Add qemu_vga.ndrv to build/pc-bios folder
2021-09-15 13:27 ` Laurent Vivier
@ 2021-09-15 13:48 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2021-09-15 13:48 UTC (permalink / raw)
To: Laurent Vivier
Cc: QEMU Trivial, John Arbuckle, Michael Tokarev, Mark Cave-Ayland,
QEMU Developers
On Wed, 15 Sept 2021 at 14:31, Laurent Vivier <laurent@vivier.eu> wrote:
>
> CC Mark
> CC qemu-devel
>
> Le 01/09/2021 à 14:16, John Arbuckle a écrit :
> > Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices.
> >
> > Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
> > ---
> > configure | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 9a79a004d7..281577e46f 100755
> > --- a/configure
> > +++ b/configure
> > @@ -5056,7 +5056,9 @@ for bios_file in \
> > $source_path/pc-bios/openbios-* \
> > $source_path/pc-bios/u-boot.* \
> > $source_path/pc-bios/edk2-*.fd.bz2 \
> > - $source_path/pc-bios/palcode-*
> > + $source_path/pc-bios/palcode-* \
> > + $source_path/pc-bios/qemu_vga.ndrv
> > +
> > do
> > LINKS="$LINKS pc-bios/$(basename $bios_file)"
The code change here is right, but Mark suggested a
commit message rewording:
https://patchew.org/QEMU/20210831165020.84855-1-programmingkidx@gmail.com/
With Mark's rewording, you can have a
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-15 14:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-31 16:50 [PATCH] Add qemu_vga.ndrv to build/pc-bios folder John Arbuckle
2021-08-31 20:33 ` Mark Cave-Ayland
2021-08-31 20:52 ` Programmingkid
2021-09-15 14:02 ` Laurent Vivier
[not found] <20210901121620.1320-1-programmingkidx@gmail.com>
2021-09-15 13:27 ` Laurent Vivier
2021-09-15 13:48 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).