From: Maxim Davydov <maxim.davydov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: den@openvz.org, mst@redhat.com, stefanha@redhat.com,
fam@euphon.net, amit@kernel.org, kraxel@redhat.com,
berrange@redhat.com, Maxim Davydov <maxim.davydov@virtuozzo.com>
Subject: [PATCH v1 7/8] virtio-blk: Add tracking of the virtio guest feature bits
Date: Wed, 1 Sep 2021 12:08:03 +0300 [thread overview]
Message-ID: <20210901090804.7139-8-maxim.davydov@virtuozzo.com> (raw)
In-Reply-To: <20210901090804.7139-1-maxim.davydov@virtuozzo.com>
Add tracking of the bits acknowledged by the guests
Signed-off-by: Maxim Davydov <maxim.davydov@virtuozzo.com>
---
hw/block/virtio-blk.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index f139cd7..552b86c 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -1287,11 +1287,13 @@ static Property virtio_blk_properties[] = {
DEFINE_BLOCK_ERROR_PROPERTIES(VirtIOBlock, conf.conf),
DEFINE_BLOCK_CHS_PROPERTIES(VirtIOBlock, conf.conf),
DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial),
- DEFINE_PROP_BIT64("config-wce", VirtIOBlock, host_features,
- VIRTIO_BLK_F_CONFIG_WCE, true),
+ DEFINE_VIRTIO_FEATURE_BIT64("config-wce", VirtIOBlock, host_features,
+ parent_obj.guest_features,
+ VIRTIO_BLK_F_CONFIG_WCE, true),
#ifdef __linux__
- DEFINE_PROP_BIT64("scsi", VirtIOBlock, host_features,
- VIRTIO_BLK_F_SCSI, false),
+ DEFINE_VIRTIO_FEATURE_BIT64("scsi", VirtIOBlock, host_features,
+ parent_obj.guest_features,
+ VIRTIO_BLK_F_SCSI, false),
#endif
DEFINE_PROP_BIT("request-merging", VirtIOBlock, conf.request_merging, 0,
true),
@@ -1301,12 +1303,14 @@ static Property virtio_blk_properties[] = {
DEFINE_PROP_BOOL("seg-max-adjust", VirtIOBlock, conf.seg_max_adjust, true),
DEFINE_PROP_LINK("iothread", VirtIOBlock, conf.iothread, TYPE_IOTHREAD,
IOThread *),
- DEFINE_PROP_BIT64("discard", VirtIOBlock, host_features,
- VIRTIO_BLK_F_DISCARD, true),
+ DEFINE_VIRTIO_FEATURE_BIT64("discard", VirtIOBlock, host_features,
+ parent_obj.guest_features,
+ VIRTIO_BLK_F_DISCARD, true),
DEFINE_PROP_BOOL("report-discard-granularity", VirtIOBlock,
conf.report_discard_granularity, true),
- DEFINE_PROP_BIT64("write-zeroes", VirtIOBlock, host_features,
- VIRTIO_BLK_F_WRITE_ZEROES, true),
+ DEFINE_VIRTIO_FEATURE_BIT64("write-zeroes", VirtIOBlock, host_features,
+ parent_obj.guest_features,
+ VIRTIO_BLK_F_WRITE_ZEROES, true),
DEFINE_PROP_UINT32("max-discard-sectors", VirtIOBlock,
conf.max_discard_sectors, BDRV_REQUEST_MAX_SECTORS),
DEFINE_PROP_UINT32("max-write-zeroes-sectors", VirtIOBlock,
--
1.8.3.1
next prev parent reply other threads:[~2021-09-01 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 9:07 [PATCH v1 0/8] Virtio features acknowledged by guest Maxim Davydov
2021-09-01 9:07 ` [PATCH v1 1/8] qdev-properties: Add read-only 64 bit property Maxim Davydov
2021-09-01 9:07 ` [PATCH v1 2/8] virtio: Add tracking of the common virtio guest features Maxim Davydov
2021-09-01 9:07 ` [PATCH v1 3/8] virtio-gpu: Add tracking of the virtio guest feature bits Maxim Davydov
2021-09-01 9:08 ` [PATCH v1 4/8] virtio-serial: " Maxim Davydov
2021-09-01 9:08 ` [PATCH v1 5/8] virtio-net: " Maxim Davydov
2021-09-01 9:08 ` [PATCH v1 6/8] scsi: Add tracking of the acknowledged " Maxim Davydov
2021-09-01 9:08 ` Maxim Davydov [this message]
2021-09-01 9:08 ` [PATCH v1 8/8] virtio-balloon: Add tracking of the virtio guest " Maxim Davydov
2021-09-02 12:34 ` [PATCH v1 0/8] Virtio features acknowledged by guest Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210901090804.7139-8-maxim.davydov@virtuozzo.com \
--to=maxim.davydov@virtuozzo.com \
--cc=amit@kernel.org \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).