From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFBCC432BE for ; Wed, 1 Sep 2021 11:36:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 437DD60F6C for ; Wed, 1 Sep 2021 11:36:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 437DD60F6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:38336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLOXk-0007dy-F5 for qemu-devel@archiver.kernel.org; Wed, 01 Sep 2021 07:36:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLNrE-0002MV-Oz for qemu-devel@nongnu.org; Wed, 01 Sep 2021 06:52:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLNrC-00019C-5a for qemu-devel@nongnu.org; Wed, 01 Sep 2021 06:52:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630493557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PqNah3n3JbPQKP3gSLt6kN+YikxKRXYtu3uyLlLh3mo=; b=hviPy3hqxzOvtNVagrjliPJX3YqRKqxFB/+DPE3v3tS90L2dDTxZ0nXuOpck9HFw4XJMNE loPKKS9BcdjJbkl9qPsrLJfinYYYSF6q2KK4SW6bb/pn+j1Vd1EDVr+jkWSdLYJHlBHpf8 3etijuWwgIb2+4cXxToHoKvrFOW6o+I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-RQ6cm7PSOOCfD8GGfPt-aA-1; Wed, 01 Sep 2021 06:52:34 -0400 X-MC-Unique: RQ6cm7PSOOCfD8GGfPt-aA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2A201107ACCD; Wed, 1 Sep 2021 10:52:33 +0000 (UTC) Received: from localhost (unknown [10.39.192.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3B285E253; Wed, 1 Sep 2021 10:52:32 +0000 (UTC) Date: Wed, 1 Sep 2021 11:52:31 +0100 From: "Richard W.M. Jones" To: Richard Henderson Subject: Re: [PULL 30/33] tcg: Allocate sufficient storage in temp_allocate_frame Message-ID: <20210901105231.GA719@redhat.com> References: <20210619181452.877683-1-richard.henderson@linaro.org> <20210619181452.877683-31-richard.henderson@linaro.org> MIME-Version: 1.0 In-Reply-To: <20210619181452.877683-31-richard.henderson@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=rjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.391, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-stable@nongnu.org, Stefan Weil , qemu-devel@nongnu.org, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Jun 19, 2021 at 11:14:49AM -0700, Richard Henderson wrote: > This function should have been updated for vector types > when they were introduced. > > Fixes: d2fd745fe8b > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/367 > Cc: qemu-stable@nongnu.org > Tested-by: Stefan Weil > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 32 +++++++++++++++++++++++++++----- > 1 file changed, 27 insertions(+), 5 deletions(-) > ... > + assert(align <= TCG_TARGET_STACK_ALIGN); This assertion is triggering: https://bugzilla.redhat.com/show_bug.cgi?id=1999878 It happens when the kernel is booting after this line: [ 7.315373] Loading compiled-in X.509 certificates If everything was working then the next line of output *should* be: Loaded X.509 cert 'Fedora kernel signing key: 65d4930f94e951d5c1531017b9559872a4e7b0b0' but instead it is: [ 7.183521] ThumbEE CPU extension supported. [ 7.186066] Registering SWP/SWPB emulation handler [ 7.304374] registered taskstats version 1 [ 7.315373] Loading compiled-in X.509 certificates qemu-system-arm: ../tcg/tcg.c:3063: temp_allocate_frame: Assertion `align <= TCG_TARGET_STACK_ALIGN' failed. Unfortunately I don't have an easy reproducer. It reproduces very reliably in Fedora's build system (qemu 6.1.0 running a TCG armv7 L2 guest on armv7 L1 host on unknown aarch64 L0 host). But my attempts to perform the same operation anywhere else don't reproduce the problem. What does the assertion mean? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW