qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, f4bug@amsat.org,
	berrange@redhat.com, qemu-stable@nongnu.org, sw@weilnetz.de
Subject: [PATCH] tcg/arm: Increase stack alignment for function generation
Date: Wed,  1 Sep 2021 17:44:45 +0100	[thread overview]
Message-ID: <20210901164446.2722007-1-rjones@redhat.com> (raw)

https://www.mail-archive.com/qemu-devel@nongnu.org/msg833146.html

I tested this patch which simply increases the stack alignment to 16
bytes and it fixes the assertion failure and otherwise appears to work
(in as far as it boots the libguestfs appliance).  However I've no
idea if this is the right thing to do.

I also had to change the tabs to spaces otherwise checkpatch
complains which makes the patch look a bit odd.

Rich.




             reply	other threads:[~2021-09-01 17:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 16:44 Richard W.M. Jones [this message]
2021-09-01 16:44 ` [PATCH] tcg/arm: Increase stack alignment for function generation Richard W.M. Jones
2021-09-01 18:18   ` Peter Maydell
2021-09-01 18:30     ` Richard W.M. Jones
2021-09-01 18:41       ` Peter Maydell
2021-09-01 18:51         ` Richard W.M. Jones
2021-09-01 20:17           ` Peter Maydell
2021-09-01 20:24             ` Richard W.M. Jones
2021-09-02  7:36               ` Peter Maydell
2021-09-02  8:06                 ` Richard W.M. Jones
2021-09-03 13:33         ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210901164446.2722007-1-rjones@redhat.com \
    --to=rjones@redhat.com \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).