From: "Richard W.M. Jones" <rjones@redhat.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, f4bug@amsat.org,
berrange@redhat.com, qemu-stable@nongnu.org, sw@weilnetz.de
Subject: [PATCH] tcg/arm: Increase stack alignment for function generation
Date: Wed, 1 Sep 2021 17:44:46 +0100 [thread overview]
Message-ID: <20210901164446.2722007-2-rjones@redhat.com> (raw)
In-Reply-To: <20210901164446.2722007-1-rjones@redhat.com>
This avoids the following assertion when the kernel initializes X.509
certificates:
[ 7.315373] Loading compiled-in X.509 certificates
qemu-system-arm: ../tcg/tcg.c:3063: temp_allocate_frame: Assertion `align <= TCG_TARGET_STACK_ALIGN' failed.
Fixes: commit c1c091948ae
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1999878
Cc: qemu-stable@nongnu.org
Tested-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
tcg/arm/tcg-target.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h
index d113b7f8db..09df3b39a1 100644
--- a/tcg/arm/tcg-target.h
+++ b/tcg/arm/tcg-target.h
@@ -115,7 +115,7 @@ extern bool use_neon_instructions;
#endif
/* used for function call generation */
-#define TCG_TARGET_STACK_ALIGN 8
+#define TCG_TARGET_STACK_ALIGN 16
#define TCG_TARGET_CALL_ALIGN_ARGS 1
#define TCG_TARGET_CALL_STACK_OFFSET 0
--
2.32.0
next prev parent reply other threads:[~2021-09-01 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 16:44 [PATCH] tcg/arm: Increase stack alignment for function generation Richard W.M. Jones
2021-09-01 16:44 ` Richard W.M. Jones [this message]
2021-09-01 18:18 ` Peter Maydell
2021-09-01 18:30 ` Richard W.M. Jones
2021-09-01 18:41 ` Peter Maydell
2021-09-01 18:51 ` Richard W.M. Jones
2021-09-01 20:17 ` Peter Maydell
2021-09-01 20:24 ` Richard W.M. Jones
2021-09-02 7:36 ` Peter Maydell
2021-09-02 8:06 ` Richard W.M. Jones
2021-09-03 13:33 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210901164446.2722007-2-rjones@redhat.com \
--to=rjones@redhat.com \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).