From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A57C433F5 for ; Fri, 3 Sep 2021 04:46:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E40960E93 for ; Fri, 3 Sep 2021 04:46:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8E40960E93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:52280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mM15i-0007Op-CY for qemu-devel@archiver.kernel.org; Fri, 03 Sep 2021 00:46:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM14O-0006jZ-KV for qemu-devel@nongnu.org; Fri, 03 Sep 2021 00:44:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:38902) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM14J-00036e-L9 for qemu-devel@nongnu.org; Fri, 03 Sep 2021 00:44:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630644286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uvhh1xAWbY8PClyav/O6viFe0r1hNIQALndx4pju0B0=; b=ZxJ0H4EuO1vb6bM0MlOQ8bkgUys5WenWuqwVeqzciFg007LfK9RUpkFH2wbqkoESzvlnw7 M0nToAyo+cRvdBzjvv0m47DNeGSTM0MGNdbkToSCnJYdiazzleuOeZg2FVolqlZBJpWuxv ETsaHdXsjLOOoGj6feRsih8IPJ57pEI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-31-JgpmoRW2PmK3OIpu-cEHiw-1; Fri, 03 Sep 2021 00:44:44 -0400 X-MC-Unique: JgpmoRW2PmK3OIpu-cEHiw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 84A2518766D6; Fri, 3 Sep 2021 04:44:43 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0896D100164A; Fri, 3 Sep 2021 04:44:32 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7D3B718000A3; Fri, 3 Sep 2021 06:44:30 +0200 (CEST) Date: Fri, 3 Sep 2021 06:44:30 +0200 From: "kraxel@redhat.com" To: VintagePC Subject: Re: USB-MSD non-functional after merging v5.1 to v6.x (seems to be internal USB stack issue?) Message-ID: <20210903044430.6h5xvq7tlhrkbxfx@sirius.home.kraxel.org> References: <20210902062232.uau63uq53akr6snr@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "marcandre.lureau@redhat.com" , "qemu-devel@nongnu.org" , "stefanha@redhat.com" , "dgilbert@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > At some point during implementation of the STM USB stack must have run > into the same problem with the communications choking during MSD init. > And at the time (which involved a LOT of wireshark comparisons with a > real USB drive on the host and on the DCW2 Rpi2 stack) I'd added the > QEMU_PACKED directive to the usb_msd_csw struct. > Thoughts? Send a patch adding the QEMU_PACKED, that should indeed be the correct fix. thanks, Gerd