From: Vladimir Sementsov-Ogievskiy via <qemu-devel@nongnu.org>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, integration@gluster.org,
kraxel@redhat.com, idryomov@gmail.com, berto@igalia.com,
philmd@redhat.com, eblake@redhat.com, pl@kamp.de,
ronniesahlberg@gmail.com, fam@euphon.net, sw@weilnetz.de,
vsementsov@virtuozzo.com, jsnow@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com, pavel.dovgaluk@ispras.ru, ari@tuxera.com,
hreitz@redhat.com, kwolf@redhat.com
Subject: [PATCH v6 01/11] block/io: bring request check to bdrv_co_(read, write)v_vmstate
Date: Fri, 3 Sep 2021 13:27:57 +0300 [thread overview]
Message-ID: <20210903102807.27127-2-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210903102807.27127-1-vsementsov@virtuozzo.com>
Only qcow2 driver supports vmstate.
In qcow2 these requests go through .bdrv_co_p{read,write}v_part
handlers.
So, let's do our basic check for the request on vmstate generic
handlers.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
block/io.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/block/io.c b/block/io.c
index a19942718b..542e0305dc 100644
--- a/block/io.c
+++ b/block/io.c
@@ -2751,7 +2751,12 @@ bdrv_co_readv_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos)
{
BlockDriver *drv = bs->drv;
BlockDriverState *child_bs = bdrv_primary_bs(bs);
- int ret = -ENOTSUP;
+ int ret;
+
+ ret = bdrv_check_qiov_request(pos, qiov->size, qiov, 0, NULL);
+ if (ret < 0) {
+ return ret;
+ }
if (!drv) {
return -ENOMEDIUM;
@@ -2763,6 +2768,8 @@ bdrv_co_readv_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos)
ret = drv->bdrv_load_vmstate(bs, qiov, pos);
} else if (child_bs) {
ret = bdrv_co_readv_vmstate(child_bs, qiov, pos);
+ } else {
+ ret = -ENOTSUP;
}
bdrv_dec_in_flight(bs);
@@ -2775,7 +2782,12 @@ bdrv_co_writev_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos)
{
BlockDriver *drv = bs->drv;
BlockDriverState *child_bs = bdrv_primary_bs(bs);
- int ret = -ENOTSUP;
+ int ret;
+
+ ret = bdrv_check_qiov_request(pos, qiov->size, qiov, 0, NULL);
+ if (ret < 0) {
+ return ret;
+ }
if (!drv) {
return -ENOMEDIUM;
@@ -2787,6 +2799,8 @@ bdrv_co_writev_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos)
ret = drv->bdrv_save_vmstate(bs, qiov, pos);
} else if (child_bs) {
ret = bdrv_co_writev_vmstate(child_bs, qiov, pos);
+ } else {
+ ret = -ENOTSUP;
}
bdrv_dec_in_flight(bs);
--
2.29.2
next prev parent reply other threads:[~2021-09-03 10:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 10:27 [PATCH v6 00/11] 64bit block-layer: part II Vladimir Sementsov-Ogievskiy
2021-09-03 10:27 ` Vladimir Sementsov-Ogievskiy via [this message]
2021-09-03 10:27 ` [PATCH v6 02/11] qcow2: check request on vmstate save/load path Vladimir Sementsov-Ogievskiy
2021-09-03 10:27 ` [PATCH v6 03/11] block: use int64_t instead of uint64_t in driver read handlers Vladimir Sementsov-Ogievskiy
2021-09-03 21:30 ` Eric Blake
2021-09-03 10:28 ` [PATCH v6 04/11] block: use int64_t instead of uint64_t in driver write handlers Vladimir Sementsov-Ogievskiy
2021-09-03 21:34 ` Eric Blake
2021-09-03 10:28 ` [PATCH v6 05/11] block: use int64_t instead of uint64_t in copy_range driver handlers Vladimir Sementsov-Ogievskiy
2021-09-03 10:28 ` [PATCH v6 06/11] block: make BlockLimits::max_pwrite_zeroes 64bit Vladimir Sementsov-Ogievskiy
2021-09-23 19:58 ` Eric Blake
2021-09-03 10:28 ` [PATCH v6 07/11] block: use int64_t instead of int in driver write_zeroes handlers Vladimir Sementsov-Ogievskiy
2021-09-23 20:33 ` Eric Blake
2021-09-23 20:53 ` Eric Blake
2021-09-23 21:50 ` Vladimir Sementsov-Ogievskiy
2021-09-03 10:28 ` [PATCH v6 08/11] block/io: allow 64bit write-zeroes requests Vladimir Sementsov-Ogievskiy
2021-09-03 10:28 ` [PATCH v6 09/11] block: make BlockLimits::max_pdiscard 64bit Vladimir Sementsov-Ogievskiy
2021-09-03 10:28 ` [PATCH v6 10/11] block: use int64_t instead of int in driver discard handlers Vladimir Sementsov-Ogievskiy
2021-09-23 20:58 ` Eric Blake
2021-09-03 10:28 ` [PATCH v6 11/11] block/io: allow 64bit discard requests Vladimir Sementsov-Ogievskiy
2021-09-22 7:52 ` [PATCH v6 00/11] 64bit block-layer: part II Vladimir Sementsov-Ogievskiy
2021-09-22 13:13 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210903102807.27127-2-vsementsov@virtuozzo.com \
--to=qemu-devel@nongnu.org \
--cc=ari@tuxera.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=idryomov@gmail.com \
--cc=integration@gluster.org \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).