From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70782C433EF for ; Fri, 3 Sep 2021 21:36:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3D2F60F21 for ; Fri, 3 Sep 2021 21:36:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E3D2F60F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMGro-0004b1-2R for qemu-devel@archiver.kernel.org; Fri, 03 Sep 2021 17:36:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMGqD-00031T-GL for qemu-devel@nongnu.org; Fri, 03 Sep 2021 17:35:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMGqB-0004Vz-VE for qemu-devel@nongnu.org; Fri, 03 Sep 2021 17:35:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630704915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SAvz3/+rLNdCGjO9/UGeVdzz5xRQ3sNfuZMjZ/LcsSo=; b=bk7kdFsYl7R31GvvPcbEG9r4LLzOGsyPTPboB5GHeG0GcPbV4Juvx9uvdGCPaDNA2b9nBJ /+cc3r0sBD6Ljaa6k0vgtzd0IQEyimjQNM3L2Yf/Etacc/npRbTIPUI22ku0N8maihnveO NWI8rbVftFdgYY5h7yYSUYQYz/1QjtE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-456-SruovtVYM9q4Ht96Vxi_Dg-1; Fri, 03 Sep 2021 17:35:13 -0400 X-MC-Unique: SruovtVYM9q4Ht96Vxi_Dg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15ED08145E5; Fri, 3 Sep 2021 21:35:12 +0000 (UTC) Received: from redhat.com (ovpn-113-81.phx2.redhat.com [10.3.113.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8C00C1B5C2; Fri, 3 Sep 2021 21:35:00 +0000 (UTC) Date: Fri, 3 Sep 2021 16:34:58 -0500 From: Eric Blake To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v6 04/11] block: use int64_t instead of uint64_t in driver write handlers Message-ID: <20210903213458.r3ut7hhprqa5a24w@redhat.com> References: <20210903102807.27127-1-vsementsov@virtuozzo.com> <20210903102807.27127-5-vsementsov@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: <20210903102807.27127-5-vsementsov@virtuozzo.com> User-Agent: NeoMutt/20210205-739-420e15 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, integration@gluster.org, berto@igalia.com, stefanha@redhat.com, qemu-block@nongnu.org, pavel.dovgaluk@ispras.ru, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, jsnow@redhat.com, hreitz@redhat.com, kraxel@redhat.com, ronniesahlberg@gmail.com, pbonzini@redhat.com, idryomov@gmail.com, philmd@redhat.com, ari@tuxera.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Sep 03, 2021 at 01:28:00PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. ... > Still, the functions may be called directly, not only by drv->... > Let's check: > > git grep '\.bdrv_\(aio\|co\)_pwritev\(_part\)\?\s*=' | \ > awk '{print $4}' | sed 's/,//' | sed 's/&//' | sort | uniq | \ > while read func; do git grep "$func(" | \ > grep -v "$func(BlockDriverState"; done > > shows several callers: > > qcow2: > qcow2_co_truncate() write at most up to @offset, which is checked in > generic qcow2_co_truncate() by bdrv_check_request(). > qcow2_co_pwritev_compressed_task() pass the request (or part of the > request) that already went through normal write path, so it should > be OK > > qcow: > qcow_co_pwritev_compressed() pass int64_t, it's updated by this patch > > quorum: > quorum_co_pwrite_zeroes() pass int64_t and int - OK > > throttle: > throttle_co_pwritev_compressed() pass int64_t, it's updated by this > patch > > vmdk: > vmdk_co_pwritev_compressed() pass int64_t, it's updated by this > patch > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org