From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80875C433EF for ; Sat, 4 Sep 2021 21:50:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45F0860F55 for ; Sat, 4 Sep 2021 21:50:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 45F0860F55 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMdYJ-0007EK-EF for qemu-devel@archiver.kernel.org; Sat, 04 Sep 2021 17:50:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMdLZ-0005vW-R8 for qemu-devel@nongnu.org; Sat, 04 Sep 2021 17:37:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMdLY-0001PM-FW for qemu-devel@nongnu.org; Sat, 04 Sep 2021 17:37:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630791428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fjJZP5VxMZRko4GDNQkgZ7w7i54b8fphWN/XvBHKOms=; b=f984nkc0jAE8KbmF66aG2vHGAJlKCmo+aRGP/jWc9B2R09Y6s/ris0eAPM/xaNTJHPyTa0 ZVrSLaoPFyBToilUMN9uOQcxt50ePm2Jd45Q9yDAOBbTvmFFQImHAEpt1lWQuN+tKZCuFs 9Nw1u0x6aRJhn8gJHRaa0UE2aL5s6MU= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-553-z8_8pSRhM2OFNZdWY7cO1A-1; Sat, 04 Sep 2021 17:37:06 -0400 X-MC-Unique: z8_8pSRhM2OFNZdWY7cO1A-1 Received: by mail-ej1-f70.google.com with SMTP id x6-20020a170906710600b005c980192a39so866175ejj.9 for ; Sat, 04 Sep 2021 14:37:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fjJZP5VxMZRko4GDNQkgZ7w7i54b8fphWN/XvBHKOms=; b=pqftAYOs90ACAXEvEeQtLXygERjiN/ZWnj578ff81ra9/9ck/9DLitA70WOHMBxTq1 abErs7quknVWobTcKsSLto5/34ecfRBFkcST8LWBBmnFX15MURGEEm49stxXa4KYva3N /+w9jDGKQlTFqfLbwBViKfJeLzXrKR8vS7OAK2bBwC3OcJ/53v73FUSdgWaTd2B+6M95 RNoqcGyxvzeIQxp7Xim2skKKD7Z5ATMuzjdM/xINcSpMrTwHb7kayE2pmcCQa2SpN39X 4uqrOq0FXlso+/5oqZQzdb/H5UcnMveoxlm45i2rK65qD2p34deiLTML8sZ9RLmWwMhe JTDA== X-Gm-Message-State: AOAM5317SFSciV9UyasWJfm8dwE/+gIzm6PpoJU1gFb6lFulS509zQKo 6oKoY9vt+DHXqIk6Ejb5G2B/lsQXbQ6IkQo2ABBO2n0R/1w3JrjMRqkaZ9zHdyVsPl1onGu4USP lclJI2LIPuIAH8Qm1G1AtF8R9f49EOyIbJIeCI2OXVJTq3wGr5w/oE7NtLaxJ X-Received: by 2002:a17:906:308d:: with SMTP id 13mr5853357ejv.570.1630791425300; Sat, 04 Sep 2021 14:37:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoJ6RQ9T6qMLAtwX62/UCwV1KIvqS1vbspdImDNMkeZDGTe4NH/kVD7CxI7VNy8lvPnp/Now== X-Received: by 2002:a17:906:308d:: with SMTP id 13mr5853344ejv.570.1630791425150; Sat, 04 Sep 2021 14:37:05 -0700 (PDT) Received: from redhat.com ([2.55.150.176]) by smtp.gmail.com with ESMTPSA id rl23sm1534197ejb.50.2021.09.04.14.37.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Sep 2021 14:37:04 -0700 (PDT) Date: Sat, 4 Sep 2021 17:37:02 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL 22/35] hw/virtio: Add flatview update in vhost_user_cleanup() Message-ID: <20210904213506.486886-23-mst@redhat.com> References: <20210904213506.486886-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210904213506.486886-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.391, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Yuwei Zhang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Yuwei Zhang Qemu will crash on vhost backend unexpected exit and re-connect │ in some case due to access released memory. Signed-off-by: Yuwei Zhang Message-Id: <20210830123433.45727-1-zhangyuwei.9149@bytedance.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 360d9bc040..2c8556237f 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -2480,7 +2480,7 @@ void vhost_user_cleanup(VhostUserState *user) if (!user->chr) { return; } - + memory_region_transaction_begin(); for (i = 0; i < VIRTIO_QUEUE_MAX; i++) { if (user->notifier[i].addr) { object_unparent(OBJECT(&user->notifier[i].mr)); @@ -2488,6 +2488,7 @@ void vhost_user_cleanup(VhostUserState *user) user->notifier[i].addr = NULL; } } + memory_region_transaction_commit(); user->chr = NULL; } -- MST