From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A44C433F5 for ; Mon, 6 Sep 2021 16:02:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0310C6023D for ; Mon, 6 Sep 2021 16:02:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0310C6023D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNH5D-0005sV-TC for qemu-devel@archiver.kernel.org; Mon, 06 Sep 2021 12:02:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNH1s-0002xc-Vd for qemu-devel@nongnu.org; Mon, 06 Sep 2021 11:59:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:25613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNH1r-0008Jo-8w for qemu-devel@nongnu.org; Mon, 06 Sep 2021 11:59:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630943966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zuxuyK2dE2WP8HJWbPjd74Fnxn986kdxEY5t1QA/lP4=; b=LhIlPq+UJoK0LKHcBgSkf9mjoM0B4flRQ4+R22OMzGsPOPiM9RU9FmdVwP67SJtwz3qy4c d6gm/fU+7B6rnatspeqrz4weVjOhiW7MAPrDGDCpLMWQUTC/LOfGhp4aB7JOABCFRh2fDM ic8eZ68Ap58dmxTChSBKzPC2UbxsTBk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-VWXsqZjGOqKVTlthsXPW-g-1; Mon, 06 Sep 2021 11:59:23 -0400 X-MC-Unique: VWXsqZjGOqKVTlthsXPW-g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80C05107ACC7; Mon, 6 Sep 2021 15:59:22 +0000 (UTC) Received: from localhost (unknown [10.39.192.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28E5C26E7B; Mon, 6 Sep 2021 15:59:21 +0000 (UTC) Date: Mon, 6 Sep 2021 16:59:21 +0100 From: "Richard W.M. Jones" To: Konstantin Kostiuk Subject: Re: Guest Agent issue with 'guest-get-osinfo' command on Windows Message-ID: <20210906155921.GU26415@redhat.com> References: <20210902135509.GU26415@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=rjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.391, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Michael Roth , Developers , Yuri Benditovich , Tomas Golembiovsky , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Yan Vugenfirer Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Sep 06, 2021 at 06:45:08PM +0300, Konstantin Kostiuk wrote: > Hi All, > > I reviewed glib, libguestfs, and libosinfo tools. All tools read the registry > to get information about Windows but read different registry values. All > information is returned in a localized form. > Related key: HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion > We can get 'pretty-name' from 'ProductName' value (all tools use it). > About 'version' there is three variant: > 1. Set 'version' equals to 'kernel-version'. libguestfs and libosinfo have this > behavior. > 2. Read 'version' from 'ReleaseId' value. glib has this behavior. In the case > of Windows Server 2022, 'ReleaseId' equals 2009. > 3. Read 'version' from 'DisplayVersion' value. In the case of Windows Server > 2022, 'DisplayVersion' equals 21H2. The important point is, however you get it, return the information as a libosinfo short value ("win2k22" in this case). > What do you think about this solution instead of using a conversion matrix? > What version we should use in this case? If you need to cover old and new versions of Windows then there's no good way. You just need lots of conditionals and to constantly evolve the code as new versions come out. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW