From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, armbru@redhat.com, hreitz@redhat.com,
kwolf@redhat.com, vsementsov@virtuozzo.com, eblake@redhat.com,
den@openvz.org
Subject: [PATCH v3 6/9] iotests.py: add qemu_tool_popen()
Date: Mon, 6 Sep 2021 22:06:51 +0300 [thread overview]
Message-ID: <20210906190654.183421-7-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210906190654.183421-1-vsementsov@virtuozzo.com>
Split qemu_tool_popen() from qemu_tool_pipe_and_status() to be used
separately.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/iotests.py | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 89663dac06..b518545c09 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -106,14 +106,21 @@ def unarchive_sample_image(sample, fname):
shutil.copyfileobj(f_in, f_out)
+def qemu_tool_popen(tool: str, args: Sequence[str],
+ connect_stderr: bool = True) -> subprocess.Popen:
+ stderr = subprocess.STDOUT if connect_stderr else None
+ return subprocess.Popen(args,
+ stdout=subprocess.PIPE,
+ stderr=stderr,
+ universal_newlines=True)
+
+
def qemu_tool_pipe_and_status(tool: str, args: Sequence[str],
connect_stderr: bool = True) -> Tuple[str, int]:
"""
Run a tool and return both its output and its exit code
"""
- stderr = subprocess.STDOUT if connect_stderr else None
- with subprocess.Popen(args, stdout=subprocess.PIPE,
- stderr=stderr, universal_newlines=True) as subp:
+ with qemu_tool_popen(tool, args, connect_stderr) as subp:
output = subp.communicate()[0]
if subp.returncode < 0:
cmd = ' '.join(args)
--
2.29.2
next prev parent reply other threads:[~2021-09-06 19:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 19:06 [PATCH v3 0/9] nbd reconnect on open Vladimir Sementsov-Ogievskiy
2021-09-06 19:06 ` [PATCH v3 1/9] nbd/client-connection: nbd_co_establish_connection(): fix non set errp Vladimir Sementsov-Ogievskiy
2021-09-07 17:44 ` Eric Blake
2021-09-24 19:19 ` Eric Blake
2021-09-06 19:06 ` [PATCH v3 2/9] qapi: make blockdev-add a coroutine command Vladimir Sementsov-Ogievskiy
2021-09-06 19:28 ` Markus Armbruster
2021-09-06 21:40 ` Vladimir Sementsov-Ogievskiy
2021-09-07 6:14 ` Markus Armbruster
2021-09-27 11:25 ` Vladimir Sementsov-Ogievskiy
2021-09-06 19:06 ` [PATCH v3 3/9] nbd: allow reconnect on open, with corresponding new options Vladimir Sementsov-Ogievskiy
2021-09-07 20:36 ` Eric Blake
2021-09-06 19:06 ` [PATCH v3 4/9] nbd/client-connection: nbd_co_establish_connection(): return real error Vladimir Sementsov-Ogievskiy
2021-09-07 20:42 ` Eric Blake
2021-09-06 19:06 ` [PATCH v3 5/9] nbd/client-connection: improve error message of cancelled attempt Vladimir Sementsov-Ogievskiy
2021-09-07 20:45 ` Eric Blake
2021-09-06 19:06 ` Vladimir Sementsov-Ogievskiy [this message]
2021-09-06 19:06 ` [PATCH v3 7/9] iotests.py: add and use qemu_io_wrap_args() Vladimir Sementsov-Ogievskiy
2021-09-06 19:06 ` [PATCH v3 8/9] iotests.py: add qemu_io_popen() Vladimir Sementsov-Ogievskiy
2021-09-06 19:06 ` [PATCH v3 9/9] iotests: add nbd-reconnect-on-open test Vladimir Sementsov-Ogievskiy
2021-09-07 20:51 ` Eric Blake
2021-09-08 7:55 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906190654.183421-7-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).