From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
Jared Rossi <jrossi@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>
Subject: [PULL 02/20] css: fix actl handling for unit exceptions
Date: Tue, 7 Sep 2021 15:14:31 +0200 [thread overview]
Message-ID: <20210907131449.493875-3-thuth@redhat.com> (raw)
In-Reply-To: <20210907131449.493875-1-thuth@redhat.com>
From: Cornelia Huck <cohuck@redhat.com>
When a subchannel becomes pending with unit exception, start
pending (and for that matter, halt or clear pending) are not
removed in the actl. Device active and subchannel active,
however, are (due to the subchannel becoming status pending
with primary respectively secondary status).
The other conditions in the actl are only cleared when the
guest executes tsch on the subchannel.
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Tested-by: Jared Rossi <jrossi@linux.ibm.com>
Message-Id: <20210705163952.736020-3-cohuck@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
include/hw/s390x/css.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h
index 10ed1df1bb..75e5381613 100644
--- a/include/hw/s390x/css.h
+++ b/include/hw/s390x/css.h
@@ -146,7 +146,8 @@ struct SubchDev {
static inline void sch_gen_unit_exception(SubchDev *sch)
{
- sch->curr_status.scsw.ctrl &= ~SCSW_ACTL_START_PEND;
+ sch->curr_status.scsw.ctrl &= ~(SCSW_ACTL_DEVICE_ACTIVE |
+ SCSW_ACTL_SUBCH_ACTIVE);
sch->curr_status.scsw.ctrl |= SCSW_STCTL_PRIMARY |
SCSW_STCTL_SECONDARY |
SCSW_STCTL_ALERT |
--
2.27.0
next prev parent reply other threads:[~2021-09-07 13:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 13:14 [PULL 00/20] s390x patches Thomas Huth
2021-09-07 13:14 ` [PULL 01/20] vfio-ccw: forward halt/clear errors Thomas Huth
2021-09-07 13:14 ` Thomas Huth [this message]
2021-09-07 13:14 ` [PULL 03/20] tests/tcg/s390x: Test SIGILL and SIGSEGV handling Thomas Huth
2021-09-07 13:14 ` [PULL 04/20] s390x/tcg: fix and optimize SPX (SET PREFIX) Thomas Huth
2021-09-07 13:14 ` [PULL 05/20] s390x/ioinst: Fix wrong MSCH alignment check on little endian Thomas Huth
2021-09-07 13:14 ` [PULL 06/20] s390x/tcg: wrap address for RRBE Thomas Huth
2021-09-07 13:14 ` [PULL 07/20] s390x/tcg: fix ignoring bit 63 when setting the storage key in SSKE Thomas Huth
2021-09-07 13:14 ` [PULL 08/20] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE Thomas Huth
2021-09-07 13:14 ` [PULL 09/20] s390x/tcg: check for addressing exceptions " Thomas Huth
2021-09-07 13:14 ` [PULL 10/20] s390x/mmu_helper: no need to pass access type to mmu_translate_asce() Thomas Huth
2021-09-07 13:14 ` [PULL 11/20] s390x/mmu_helper: fixup mmu_translate() documentation Thomas Huth
2021-09-07 13:14 ` [PULL 12/20] s390x/mmu_helper: move address validation into mmu_translate*() Thomas Huth
2021-09-07 13:14 ` [PULL 13/20] s390x/mmu_helper: avoid setting the storage key if nothing changed Thomas Huth
2021-09-07 13:14 ` [PULL 14/20] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to migrate Thomas Huth
2021-09-07 13:14 ` [PULL 15/20] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to dump Thomas Huth
2021-09-07 13:14 ` [PULL 16/20] hw/s390x/s390-skeys: check if an address is valid before dumping the key Thomas Huth
2021-09-07 13:14 ` [PULL 17/20] hw/s390x/s390-skeys: rename skeys_enabled to skeys_are_enabled Thomas Huth
2021-09-07 13:14 ` [PULL 18/20] hw/s390x/s390-skeys: lazy storage key enablement under TCG Thomas Huth
2021-09-07 13:14 ` [PULL 19/20] s390x: Replace PAGE_SIZE, PAGE_SHIFT and PAGE_MASK Thomas Huth
2021-09-07 13:14 ` [PULL 20/20] s390x/cpumodel: Add more feature to gen16 default model Thomas Huth
2021-09-07 19:22 ` [PULL 00/20] s390x patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907131449.493875-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=cohuck@redhat.com \
--cc=jrossi@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).