* [PATCH] meson: do not use python.full_path() unnecessarily
@ 2021-09-08 10:13 Paolo Bonzini
2021-09-08 10:43 ` Daniel P. Berrangé
2021-09-08 10:44 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-09-08 10:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau
The "python" variable is an external program and can be passed
directly to custom_target. This avoids the need to look it up
multiple times, which was previously silent but is now explicit
in recent Meson versions.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
ui/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/meson.build b/ui/meson.build
index 7d25c1b95b..7faa42eb3f 100644
--- a/ui/meson.build
+++ b/ui/meson.build
@@ -134,7 +134,7 @@ if have_system or xkbcommon.found()
output: output,
capture: true,
input: files('keycodemapdb/data/keymaps.csv'),
- command: [python.full_path(), files('keycodemapdb/tools/keymap-gen'),
+ command: [python, files('keycodemapdb/tools/keymap-gen'),
'code-map',
'--lang', 'glib2',
'--varname', 'qemu_input_map_@0@_to_@1@'.format(e[0], e[1]),
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] meson: do not use python.full_path() unnecessarily
2021-09-08 10:13 [PATCH] meson: do not use python.full_path() unnecessarily Paolo Bonzini
@ 2021-09-08 10:43 ` Daniel P. Berrangé
2021-09-08 10:44 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2021-09-08 10:43 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Marc-André Lureau, qemu-devel
On Wed, Sep 08, 2021 at 12:13:32PM +0200, Paolo Bonzini wrote:
> The "python" variable is an external program and can be passed
> directly to custom_target. This avoids the need to look it up
> multiple times, which was previously silent but is now explicit
> in recent Meson versions.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> ui/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] meson: do not use python.full_path() unnecessarily
2021-09-08 10:13 [PATCH] meson: do not use python.full_path() unnecessarily Paolo Bonzini
2021-09-08 10:43 ` Daniel P. Berrangé
@ 2021-09-08 10:44 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-08 10:44 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: Marc-André Lureau
On 9/8/21 12:13 PM, Paolo Bonzini wrote:
> The "python" variable is an external program and can be passed
> directly to custom_target. This avoids the need to look it up
> multiple times, which was previously silent but is now explicit
> in recent Meson versions.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> ui/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-08 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-08 10:13 [PATCH] meson: do not use python.full_path() unnecessarily Paolo Bonzini
2021-09-08 10:43 ` Daniel P. Berrangé
2021-09-08 10:44 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).