From: Yang Zhong <yang.zhong@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: yang.zhong@intel.com, pbonzini@redhat.com, eblake@redhat.com,
qemu-devel@nongnu.org, seanjc@google.com
Subject: Re: [PATCH 3/7] i386: Add sgx_get_info() interface
Date: Thu, 9 Sep 2021 15:05:03 +0800 [thread overview]
Message-ID: <20210909070503.GF21362@yangzhon-Virtual> (raw)
In-Reply-To: <b8008d89-1b18-de17-59b9-557e59f499b8@redhat.com>
On Wed, Sep 08, 2021 at 10:55:13AM +0200, Paolo Bonzini wrote:
> On 08/09/21 10:19, Yang Zhong wrote:
> >+ if (x86ms->sgx_epc_list) {
> >+ PCMachineState *pcms = PC_MACHINE(ms);
> >+ SGXEPCState *sgx_epc = &pcms->sgx_epc;
> >+ info = g_new0(SGXInfo, 1);
> >+
> >+ info->sgx = true;
> >+ info->sgx1 = true;
> >+ info->sgx2 = true;
> >+ info->flc = true;
>
> Since this is querying the actual machine, it should check the CPUID
> bits of the first CPU, instead of just returning true.
>
Paolo, this interface is only for checking SGX info from VM side by
motinor or QMP tools, the SGXInfo *sgx_get_capabilities(Error **errp)
in the patch5 check the host cpuid info to get the SGX related CPU bit
info, like sgx,flc,sgx1,and sgx2 bit info. so here, if x86ms->sgx_epc_list
is setting, those bits info in the VM side are all ture. thanks!
Yang
> Paolo
next prev parent reply other threads:[~2021-09-09 7:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 8:19 [PATCH 0/7] The HMP/QMP interfaces in Qemu SGX Yang Zhong
2021-09-08 8:19 ` [PATCH 1/7] qmp: Add query-sgx command Yang Zhong
2021-09-08 8:19 ` [PATCH 2/7] hmp: Add 'info sgx' command Yang Zhong
2021-09-08 8:19 ` [PATCH 3/7] i386: Add sgx_get_info() interface Yang Zhong
2021-09-08 8:32 ` Philippe Mathieu-Daudé
2021-09-09 2:20 ` Yang Zhong
2021-09-08 8:55 ` Paolo Bonzini
2021-09-09 7:05 ` Yang Zhong [this message]
2021-09-08 8:19 ` [PATCH 4/7] bitops: Support 32 and 64 bit mask macro Yang Zhong
2021-09-08 8:34 ` Philippe Mathieu-Daudé
2021-09-09 2:04 ` Yang Zhong
2021-09-08 8:19 ` [PATCH 5/7] qmp: Add the qmp_query_sgx_capabilities() Yang Zhong
2021-09-08 8:38 ` Philippe Mathieu-Daudé
2021-09-09 2:51 ` Yang Zhong
2021-09-09 9:36 ` Philippe Mathieu-Daudé
2021-09-09 12:06 ` Yang Zhong
2021-09-09 13:25 ` Philippe Mathieu-Daudé
2021-09-08 8:19 ` [PATCH 6/7] monitor: Fix coredump issue in non-x86 platform Yang Zhong
2021-09-08 8:53 ` Philippe Mathieu-Daudé
2021-09-08 8:54 ` Paolo Bonzini
2021-09-09 6:48 ` Yang Zhong
2021-09-08 8:19 ` [PATCH 7/7] pc: Cleanup the SGX definitions Yang Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909070503.GF21362@yangzhon-Virtual \
--to=yang.zhong@intel.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).