From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PULL 0/6] Vga 20210910 patches
Date: Tue, 14 Sep 2021 09:11:33 +0200 [thread overview]
Message-ID: <20210914071133.wvgbf5ezcpbd4kr3@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA_1SdGuiEgquVE2T5p-x6YkJXwAou==wdVoZvRqcZzJDg@mail.gmail.com>
On Fri, Sep 10, 2021 at 05:52:55PM +0100, Peter Maydell wrote:
> On Fri, 10 Sept 2021 at 14:19, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > The following changes since commit bd662023e683850c085e98c8ff8297142c2dd9f2:
> >
> > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20210908' into staging (2021-09-08 11:06:17 +0100)
> >
> > are available in the Git repository at:
> >
> > git://git.kraxel.org/qemu tags/vga-20210910-pull-request
> >
> > for you to fetch changes up to 6335c0b56819a5d1219ea84a11a732d0861542db:
> >
> > qxl: fix pre-save logic (2021-09-10 12:23:12 +0200)
> >
> > ----------------------------------------------------------------
> > virtio-gpu + ui: fence syncronization.
> > qxl: unbreak live migration.
> >
> > ----------------------------------------------------------------
>
> Hi; this fails to build on the ppc64 system:
>
> ../../ui/egl-helpers.c:79:6: error: no previous prototype for
> 'egl_dmabuf_create_sync' [-Werror=missing-prototypes]
> 79 | void egl_dmabuf_create_sync(QemuDmaBuf *dmabuf)
> | ^~~~~~~~~~~~~~~~~~~~~~
> ../../ui/egl-helpers.c:95:6: error: no previous prototype for
> 'egl_dmabuf_create_fence' [-Werror=missing-prototypes]
> 95 | void egl_dmabuf_create_fence(QemuDmaBuf *dmabuf)
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
>
> The prototype is hidden behind CONFIG_GBM, but the definition is not.
>
> Then the callsites fail:
>
> ../../ui/gtk-gl-area.c: In function 'gd_gl_area_draw':
> ../../ui/gtk-gl-area.c:77:9: error: implicit declaration of function
> 'egl_dmabuf_create_sync' [-Werror=implicit-function-declaration]
> 77 | egl_dmabuf_create_sync(dmabuf);
> | ^~~~~~~~~~~~~~~~~~~~~~
> ../../ui/gtk-gl-area.c:77:9: error: nested extern declaration of
> 'egl_dmabuf_create_sync' [-Werror=nested-externs]
> ../../ui/gtk-gl-area.c:81:9: error: implicit declaration of function
> 'egl_dmabuf_create_fence' [-Werror=implicit-function-declaration]
> 81 | egl_dmabuf_create_fence(dmabuf);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> ../../ui/gtk-gl-area.c:81:9: error: nested extern declaration of
> 'egl_dmabuf_create_fence' [-Werror=nested-externs]
>
>
> ../../ui/gtk-egl.c: In function 'gd_egl_draw':
> ../../ui/gtk-egl.c:100:9: error: implicit declaration of function
> 'egl_dmabuf_create_fence' [-Werror=implicit-function-declaration]
> 100 | egl_dmabuf_create_fence(dmabuf);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> ../../ui/gtk-egl.c:100:9: error: nested extern declaration of
> 'egl_dmabuf_create_fence' [-Werror=nested-externs]
> ../../ui/gtk-egl.c: In function 'gd_egl_scanout_flush':
> ../../ui/gtk-egl.c:301:9: error: implicit declaration of function
> 'egl_dmabuf_create_sync' [-Werror=implicit-function-declaration]
> 301 | egl_dmabuf_create_sync(vc->gfx.guest_fb.dmabuf);
> | ^~~~~~~~~~~~~~~~~~~~~~
> ../../ui/gtk-egl.c:301:9: error: nested extern declaration of
> 'egl_dmabuf_create_sync' [-Werror=nested-externs]
>
>
> You can probably repro this on any system which has the opengl
> libraries installed but not libgbm.
Vivek? Can you have a look please?
thanks,
Gerd
next prev parent reply other threads:[~2021-09-14 7:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 13:17 [PULL 0/6] Vga 20210910 patches Gerd Hoffmann
2021-09-10 13:17 ` [PULL 1/6] ui/gtk: Create a common release_dmabuf helper Gerd Hoffmann
2021-09-10 13:17 ` [PULL 2/6] ui/egl: Add egl helpers to help with synchronization Gerd Hoffmann
2021-09-10 13:17 ` [PULL 3/6] ui: Create sync objects and fences only for blobs Gerd Hoffmann
2021-09-10 13:17 ` [PULL 4/6] ui/gtk-egl: Wait for the draw signal for dmabuf blobs Gerd Hoffmann
2021-09-10 13:17 ` [PULL 5/6] virtio-gpu: Add gl_flushed callback Gerd Hoffmann
2021-09-10 13:17 ` [PULL 6/6] qxl: fix pre-save logic Gerd Hoffmann
2021-09-10 16:52 ` [PULL 0/6] Vga 20210910 patches Peter Maydell
2021-09-14 7:11 ` Gerd Hoffmann [this message]
2021-09-14 22:05 ` Kasireddy, Vivek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914071133.wvgbf5ezcpbd4kr3@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).