From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, hreitz@redhat.com, kwolf@redhat.com,
vsementsov@virtuozzo.com, jsnow@redhat.com,
Max Reitz <mreitz@redhat.com>
Subject: [PATCH v3 01/17] iotests.py: img_info_log(): rename imgopts argument
Date: Tue, 14 Sep 2021 13:25:31 +0300 [thread overview]
Message-ID: <20210914102547.83963-2-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210914102547.83963-1-vsementsov@virtuozzo.com>
We are going to support IMGOPTS environment variable like in bash
tests. Corresponding global variable in iotests.py should be called
imgopts. So to not interfere with function argument, rename it in
advance.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/210 | 8 ++++----
tests/qemu-iotests/iotests.py | 5 +++--
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/210 b/tests/qemu-iotests/210
index 5a62ed4dd1..79b4967225 100755
--- a/tests/qemu-iotests/210
+++ b/tests/qemu-iotests/210
@@ -62,7 +62,7 @@ with iotests.FilePath('t.luks') as disk_path, \
'driver=luks,file.driver=file,file.filename=%s,key-secret=keysec0' % (disk_path),
filter_path=disk_path,
extra_args=['--object', 'secret,id=keysec0,data=foo'],
- imgopts=True)
+ use_image_opts=True)
#
# Successful image creation (with non-default options)
@@ -96,7 +96,7 @@ with iotests.FilePath('t.luks') as disk_path, \
'driver=luks,file.driver=file,file.filename=%s,key-secret=keysec0' % (disk_path),
filter_path=disk_path,
extra_args=['--object', 'secret,id=keysec0,data=foo'],
- imgopts=True)
+ use_image_opts=True)
#
# Invalid BlockdevRef
@@ -132,7 +132,7 @@ with iotests.FilePath('t.luks') as disk_path, \
'driver=luks,file.driver=file,file.filename=%s,key-secret=keysec0' % (disk_path),
filter_path=disk_path,
extra_args=['--object', 'secret,id=keysec0,data=foo'],
- imgopts=True)
+ use_image_opts=True)
#
# Invalid sizes
@@ -176,4 +176,4 @@ with iotests.FilePath('t.luks') as disk_path, \
'driver=luks,file.driver=file,file.filename=%s,key-secret=keysec0' % (disk_path),
filter_path=disk_path,
extra_args=['--object', 'secret,id=keysec0,data=foo'],
- imgopts=True)
+ use_image_opts=True)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 11276f380a..782d4f0e21 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -205,9 +205,10 @@ def qemu_img_log(*args):
log(result, filters=[filter_testfiles])
return result
-def img_info_log(filename, filter_path=None, imgopts=False, extra_args=()):
+def img_info_log(filename, filter_path=None, use_image_opts=False,
+ extra_args=()):
args = ['info']
- if imgopts:
+ if use_image_opts:
args.append('--image-opts')
else:
args += ['-f', imgfmt]
--
2.29.2
next prev parent reply other threads:[~2021-09-14 10:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 10:25 [PATCH v3 00/17] iotests: support zstd Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` Vladimir Sementsov-Ogievskiy [this message]
2021-09-14 10:25 ` [PATCH v3 02/17] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd' Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 03/17] iotests: drop qemu_img_verbose() helper Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 04/17] iotests.py: rewrite default luks support in qemu_img Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 05/17] iotest 303: explicit compression type Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 06/17] iotest 065: " Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 07/17] iotests.py: filter out successful output of qemu-img create Vladimir Sementsov-Ogievskiy
2021-09-14 17:04 ` Hanna Reitz
2021-09-14 10:25 ` [PATCH v3 08/17] iotests.py: filter compression type out Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 09/17] iotest 302: use img_info_log() helper Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 10/17] qcow2: simple case support for downgrading of qcow2 images with zstd Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 11/17] iotests/common.rc: introduce _qcow2_dump_header helper Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 12/17] iotests: massive use _qcow2_dump_header Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 13/17] iotest 39: " Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 14/17] iotests: bash tests: filter compression type Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 15/17] iotests 60: more accurate set dirty bit in qcow2 header Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 16/17] iotest 214: explicit compression type Vladimir Sementsov-Ogievskiy
2021-09-14 10:25 ` [PATCH v3 17/17] iotests: declare lack of support for compresion_type in IMGOPTS Vladimir Sementsov-Ogievskiy
2021-09-14 17:08 ` [PATCH v3 00/17] iotests: support zstd Hanna Reitz
2021-10-07 16:29 ` Vladimir Sementsov-Ogievskiy
2021-10-08 6:39 ` Hanna Reitz
2021-10-08 9:22 ` Vladimir Sementsov-Ogievskiy
2021-09-15 14:45 ` Hanna Reitz
2021-09-17 14:49 ` Hanna Reitz
2021-09-17 18:06 ` Vladimir Sementsov-Ogievskiy
2021-11-02 12:29 ` Kevin Wolf
2021-11-03 13:01 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914102547.83963-2-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).