qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, hreitz@redhat.com, kwolf@redhat.com,
	den@openvz.org, ktkhai@virtuozzo.com, eblake@redhat.com,
	berto@igalia.com, vsementsov@virtuozzo.com
Subject: [PATCH v4 00/10] qcow2 check: check some reserved bits and subcluster bitmaps
Date: Tue, 14 Sep 2021 15:24:44 +0300	[thread overview]
Message-ID: <20210914122454.141075-1-vsementsov@virtuozzo.com> (raw)

Hi all!

Here are some good refactorings and new (qemu-img check) checks for
qcow2.

06  qcow2-refcount: check_refcounts_l2(): check l2_bitmap
      don't fix unallocated cluster with allocated subclusters (no strong opinion how to do it correctly)
      drop Eric's r-b
      keep Kirill's t-b (I believe it still applies, my original task didn't include error fixing)
      define l2_bitmap near l2_entry
      add separate assertion and "break;" for QCOW2_CLUSTER_ZERO_PLAIN
others: add r-b: Hanna


Vladimir Sementsov-Ogievskiy (10):
  qcow2-refcount: improve style of check_refcounts_l2()
  qcow2: compressed read: simplify cluster descriptor passing
  qcow2: introduce qcow2_parse_compressed_l2_entry() helper
  qcow2-refcount: introduce fix_l2_entry_by_zero()
  qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap
  qcow2-refcount: check_refcounts_l2(): check l2_bitmap
  qcow2-refcount: check_refcounts_l2(): check reserved bits
  qcow2-refcount: improve style of check_refcounts_l1()
  qcow2-refcount: check_refcounts_l1(): check reserved bits
  qcow2-refcount: check_refblocks(): add separate message for reserved

 block/qcow2.h          |   7 +-
 block/qcow2-cluster.c  |  20 ++-
 block/qcow2-refcount.c | 324 ++++++++++++++++++++++++++---------------
 block/qcow2.c          |  13 +-
 4 files changed, 236 insertions(+), 128 deletions(-)

-- 
2.29.2



             reply	other threads:[~2021-09-14 12:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 12:24 Vladimir Sementsov-Ogievskiy [this message]
2021-09-14 12:24 ` [PATCH v4 01/10] qcow2-refcount: improve style of check_refcounts_l2() Vladimir Sementsov-Ogievskiy
2021-09-14 12:24 ` [PATCH v4 02/10] qcow2: compressed read: simplify cluster descriptor passing Vladimir Sementsov-Ogievskiy
2021-09-14 12:24 ` [PATCH v4 03/10] qcow2: introduce qcow2_parse_compressed_l2_entry() helper Vladimir Sementsov-Ogievskiy
2021-09-14 12:24 ` [PATCH v4 04/10] qcow2-refcount: introduce fix_l2_entry_by_zero() Vladimir Sementsov-Ogievskiy
2021-09-14 12:24 ` [PATCH v4 05/10] qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap Vladimir Sementsov-Ogievskiy
2021-09-14 12:24 ` [PATCH v4 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap Vladimir Sementsov-Ogievskiy
2021-09-14 14:25   ` Eric Blake
2021-09-14 14:26     ` Vladimir Sementsov-Ogievskiy
2021-09-14 17:12   ` Hanna Reitz
2021-09-14 12:24 ` [PATCH v4 07/10] qcow2-refcount: check_refcounts_l2(): check reserved bits Vladimir Sementsov-Ogievskiy
2021-09-14 17:15   ` Hanna Reitz
2021-09-15  6:59     ` Vladimir Sementsov-Ogievskiy
2021-09-14 12:24 ` [PATCH v4 08/10] qcow2-refcount: improve style of check_refcounts_l1() Vladimir Sementsov-Ogievskiy
2021-09-14 12:24 ` [PATCH v4 09/10] qcow2-refcount: check_refcounts_l1(): check reserved bits Vladimir Sementsov-Ogievskiy
2021-09-14 12:24 ` [PATCH v4 10/10] qcow2-refcount: check_refblocks(): add separate message for reserved Vladimir Sementsov-Ogievskiy
2021-09-15 10:26 ` [PATCH v4 00/10] qcow2 check: check some reserved bits and subcluster bitmaps Hanna Reitz
2021-09-15 11:36   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210914122454.141075-1-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=berto@igalia.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=ktkhai@virtuozzo.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).