* Re: [PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist
2021-09-14 12:32 [PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist Thomas Huth
@ 2021-09-14 12:53 ` Vivek Goyal
2021-09-14 13:32 ` [Virtio-fs] " Sergio Lopez
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Vivek Goyal @ 2021-09-14 12:53 UTC (permalink / raw)
To: Thomas Huth
Cc: virtio-fs, qemu-s390x, qemu-devel, Stefan Hajnoczi,
Dr. David Alan Gilbert
On Tue, Sep 14, 2021 at 02:32:14PM +0200, Thomas Huth wrote:
> The virtiofsd currently crashes on s390x when doing something like
> this in the guest:
>
> mkdir -p /mnt/myfs
> mount -t virtiofs myfs /mnt/myfs
> touch /mnt/myfs/foo.txt
> stat -f /mnt/myfs/foo.txt
>
> The problem is that the fstatfs64 syscall is called in this case
> from the virtiofsd. We have to put it on the seccomp allowlist to
> avoid that the daemon gets killed in this case.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2001728
> Suggested-by: Vivek Goyal <vgoyal@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
Thanks Thomas for the patch.
Vivek
> ---
> tools/virtiofsd/passthrough_seccomp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c
> index f49ed94b5e..a3ce9f898d 100644
> --- a/tools/virtiofsd/passthrough_seccomp.c
> +++ b/tools/virtiofsd/passthrough_seccomp.c
> @@ -51,6 +51,7 @@ static const int syscall_allowlist[] = {
> SCMP_SYS(fsetxattr),
> SCMP_SYS(fstat),
> SCMP_SYS(fstatfs),
> + SCMP_SYS(fstatfs64),
> SCMP_SYS(fsync),
> SCMP_SYS(ftruncate),
> SCMP_SYS(futex),
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Virtio-fs] [PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist
2021-09-14 12:32 [PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist Thomas Huth
2021-09-14 12:53 ` Vivek Goyal
@ 2021-09-14 13:32 ` Sergio Lopez
2021-09-15 14:45 ` Stefan Hajnoczi
2021-09-16 9:44 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 5+ messages in thread
From: Sergio Lopez @ 2021-09-14 13:32 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Dr. David Alan Gilbert, virtio-fs, qemu-s390x,
Stefan Hajnoczi, Vivek Goyal
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
On Tue, Sep 14, 2021 at 02:32:14PM +0200, Thomas Huth wrote:
> The virtiofsd currently crashes on s390x when doing something like
> this in the guest:
>
> mkdir -p /mnt/myfs
> mount -t virtiofs myfs /mnt/myfs
> touch /mnt/myfs/foo.txt
> stat -f /mnt/myfs/foo.txt
>
> The problem is that the fstatfs64 syscall is called in this case
> from the virtiofsd. We have to put it on the seccomp allowlist to
> avoid that the daemon gets killed in this case.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2001728
> Suggested-by: Vivek Goyal <vgoyal@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tools/virtiofsd/passthrough_seccomp.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Sergio Lopez <slp@redhat.com>
> diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c
> index f49ed94b5e..a3ce9f898d 100644
> --- a/tools/virtiofsd/passthrough_seccomp.c
> +++ b/tools/virtiofsd/passthrough_seccomp.c
> @@ -51,6 +51,7 @@ static const int syscall_allowlist[] = {
> SCMP_SYS(fsetxattr),
> SCMP_SYS(fstat),
> SCMP_SYS(fstatfs),
> + SCMP_SYS(fstatfs64),
> SCMP_SYS(fsync),
> SCMP_SYS(ftruncate),
> SCMP_SYS(futex),
> --
> 2.27.0
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://listman.redhat.com/mailman/listinfo/virtio-fs
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist
2021-09-14 12:32 [PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist Thomas Huth
2021-09-14 12:53 ` Vivek Goyal
2021-09-14 13:32 ` [Virtio-fs] " Sergio Lopez
@ 2021-09-15 14:45 ` Stefan Hajnoczi
2021-09-16 9:44 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2021-09-15 14:45 UTC (permalink / raw)
To: Thomas Huth
Cc: virtio-fs, qemu-s390x, qemu-devel, Vivek Goyal,
Dr. David Alan Gilbert
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Tue, Sep 14, 2021 at 02:32:14PM +0200, Thomas Huth wrote:
> The virtiofsd currently crashes on s390x when doing something like
> this in the guest:
>
> mkdir -p /mnt/myfs
> mount -t virtiofs myfs /mnt/myfs
> touch /mnt/myfs/foo.txt
> stat -f /mnt/myfs/foo.txt
>
> The problem is that the fstatfs64 syscall is called in this case
> from the virtiofsd. We have to put it on the seccomp allowlist to
> avoid that the daemon gets killed in this case.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2001728
> Suggested-by: Vivek Goyal <vgoyal@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tools/virtiofsd/passthrough_seccomp.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist
2021-09-14 12:32 [PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist Thomas Huth
` (2 preceding siblings ...)
2021-09-15 14:45 ` Stefan Hajnoczi
@ 2021-09-16 9:44 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2021-09-16 9:44 UTC (permalink / raw)
To: Thomas Huth
Cc: virtio-fs, qemu-s390x, qemu-devel, Stefan Hajnoczi, Vivek Goyal
* Thomas Huth (thuth@redhat.com) wrote:
> The virtiofsd currently crashes on s390x when doing something like
> this in the guest:
>
> mkdir -p /mnt/myfs
> mount -t virtiofs myfs /mnt/myfs
> touch /mnt/myfs/foo.txt
> stat -f /mnt/myfs/foo.txt
>
> The problem is that the fstatfs64 syscall is called in this case
> from the virtiofsd. We have to put it on the seccomp allowlist to
> avoid that the daemon gets killed in this case.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2001728
> Suggested-by: Vivek Goyal <vgoyal@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, and queued.
> ---
> tools/virtiofsd/passthrough_seccomp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c
> index f49ed94b5e..a3ce9f898d 100644
> --- a/tools/virtiofsd/passthrough_seccomp.c
> +++ b/tools/virtiofsd/passthrough_seccomp.c
> @@ -51,6 +51,7 @@ static const int syscall_allowlist[] = {
> SCMP_SYS(fsetxattr),
> SCMP_SYS(fstat),
> SCMP_SYS(fstatfs),
> + SCMP_SYS(fstatfs64),
> SCMP_SYS(fsync),
> SCMP_SYS(ftruncate),
> SCMP_SYS(futex),
> --
> 2.27.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread