qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
	kwolf@redhat.com, hreitz@redhat.com, vsementsov@virtuozzo.com,
	jsnow@redhat.com, Eric Blake <eblake@redhat.com>
Subject: [PULL 04/12] job: Force-cancel jobs in a failed transaction
Date: Tue, 21 Sep 2021 13:20:09 +0300	[thread overview]
Message-ID: <20210921102017.273679-5-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210921102017.273679-1-vsementsov@virtuozzo.com>

From: Hanna Reitz <hreitz@redhat.com>

When a transaction is aborted, no result matters, and so all jobs within
should be force-cancelled.

Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210907124245.143492-5-hreitz@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 job.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/job.c b/job.c
index 810e6a2065..e74d81928d 100644
--- a/job.c
+++ b/job.c
@@ -766,7 +766,12 @@ static void job_completed_txn_abort(Job *job)
         if (other_job != job) {
             ctx = other_job->aio_context;
             aio_context_acquire(ctx);
-            job_cancel_async(other_job, false);
+            /*
+             * This is a transaction: If one job failed, no result will matter.
+             * Therefore, pass force=true to terminate all other jobs as quickly
+             * as possible.
+             */
+            job_cancel_async(other_job, true);
             aio_context_release(ctx);
         }
     }
-- 
2.29.2



  parent reply	other threads:[~2021-09-21 10:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21 10:20 [PULL 00/12] jobs: mirror: Handle errors after READY cancel Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` [PULL 01/12] job: Context changes in job_completed_txn_abort() Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` [PULL 02/12] mirror: Keep s->synced on error Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` [PULL 03/12] mirror: Drop s->synced Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` Vladimir Sementsov-Ogievskiy [this message]
2021-09-21 10:20 ` [PULL 05/12] job: @force parameter for job_cancel_sync() Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` [PULL 06/12] jobs: Give Job.force_cancel more meaning Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` [PULL 07/12] job: Add job_cancel_requested() Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` [PULL 08/12] mirror: Use job_is_cancelled() Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` [PULL 09/12] mirror: Check job_is_cancelled() earlier Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` [PULL 10/12] mirror: Stop active mirroring after force-cancel Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` [PULL 11/12] mirror: Do not clear .cancelled Vladimir Sementsov-Ogievskiy
2021-09-21 10:20 ` [PULL 12/12] iotests: Add mirror-ready-cancel-error test Vladimir Sementsov-Ogievskiy
2021-09-22 16:05 ` [PULL 00/12] jobs: mirror: Handle errors after READY cancel Richard Henderson
2021-09-22 19:19   ` Vladimir Sementsov-Ogievskiy
2021-09-23 22:01     ` Vladimir Sementsov-Ogievskiy
2021-10-04 16:47       ` Hanna Reitz
2021-10-04 17:59         ` Vladimir Sementsov-Ogievskiy
2021-10-05 15:03           ` Hanna Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210921102017.273679-5-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).